Fixed invalid Promise syntax in Plotly.plot

Author: Tom Chandler

src/plot_api/plot_api.js

@@ -59,7 +59,7 @@ Plotly.plot = function(gd, data, layout, config) {
     Events.init(gd);
 
     var okToPlot = Events.triggerHandler(gd, 'plotly_beforeplot', [data, layout, config]);
-    if(okToPlot===false) return new Promise.reject();
+    if(okToPlot===false) return Promise.reject();
 
     // if there's no data or layout, and this isn't yet a plotly plot
     // container, log a warning to help plotly.js users debug
@@ -112,7 +112,7 @@ Plotly.plot = function(gd, data, layout, config) {
         // signal to drag handler that after everything else is done
         // we need to replot, because something has changed
         gd._replotPending = true;
-        return new Promise.reject();
+        return Promise.reject();
     } else {
         // we're going ahead with a replot now
         gd._replotPending = false;

test/jasmine/tests/plot_promise_test.js

@@ -1,4 +1,5 @@
 var Plotly = require('@src/plotly');
+var Events = require('@src/lib/events');
 var createGraphDiv = require('../assets/create_graph_div');
 var destroyGraphDiv = require('../assets/destroy_graph_div');
 
@@ -29,6 +30,64 @@ describe('Plotly.___ methods', function() {
         });
     });
 
+    describe('Plotly.plot promise', function() {
+        var gd,
+            promise,
+            promiseRejected = false;
+
+        beforeEach(function(done) {
+            var data = [{ x: [1,2,3], y: [4,5,6] }];
+
+            gd = createGraphDiv();
+
+            Events.init(gd);
+
+            gd.on('plotly_beforeplot', function() {
+                return false;
+            });
+
+            promise = Plotly.plot(gd, data, {});
+
+            promise.then(null, function(){
+                promiseRejected = true;
+                done();
+            });
+        });
+
+        afterEach(destroyGraphDiv);
+
+        it('should be rejected when plotly_beforeplot event handlers return false', function() {
+            expect(promiseRejected).toBe(true);
+        });
+    });
+
+    describe('Plotly.plot promise', function() {
+        var gd,
+            promise,
+            promiseRejected = false;
+
+        beforeEach(function(done) {
+            var data = [{ x: [1,2,3], y: [4,5,6] }];
+
+            gd = createGraphDiv();
+
+            gd._dragging = true;
+
+            promise = Plotly.plot(gd, data, {});
+
+            promise.then(null, function(){
+                promiseRejected = true;
+                done();
+            });
+        });
+
+        afterEach(destroyGraphDiv);
+
+        it('should reject the promise when graph is being dragged', function() {
+            expect(promiseRejected).toBe(true);
+        });
+    });
+
     describe('Plotly.redraw promise', function() {
         var promise,
             promiseGd;