better pad value for autoranged cones

Author: etpinard

src/plots/gl3d/scene.js

@@ -508,7 +508,7 @@ proto.plot = function(sceneData, fullLayout, layout) {
                 var obj = objects[j];
                 var objBounds = obj.bounds;
                 // add worse-case pad for cone traces
-                var pad = (obj._trace.data._normMax || 0) * dataScale[i];
+                var pad = 0.75 * (obj._trace.data._compMax || 0) * dataScale[i];
                 sceneBounds[0][i] = Math.min(sceneBounds[0][i], objBounds[0][i] / dataScale[i] - pad);
                 sceneBounds[1][i] = Math.max(sceneBounds[1][i], objBounds[1][i] / dataScale[i] + pad);
             }

src/traces/cone/calc.js

@@ -17,18 +17,26 @@ module.exports = function calc(gd, trace) {
     var len = Math.min(u.length, v.length, w.length);
     var normMax = -Infinity;
     var normMin = Infinity;
+    var compMax = -Infinity;
 
     for(var i = 0; i < len; i++) {
         var uu = u[i];
+        var u2 = uu * uu;
         var vv = v[i];
+        var v2 = vv * vv;
         var ww = w[i];
-        var norm = Math.sqrt(uu * uu + vv * vv + ww * ww);
+        var w2 = ww * ww;
+        var norm = Math.sqrt(u2 + v2 + w2);
 
         normMax = Math.max(normMax, norm);
         normMin = Math.min(normMin, norm);
+        compMax = Math.max(compMax, u2, v2, w2);
     }
 
+    // stash max norm value to convert cmix/cmax -> vertexIntensityBounds
     trace._normMax = normMax;
+    // stash max 'component' value for autorange pad
+    trace._compMax = Math.sqrt(compMax);
 
     colorscaleCalc(trace, [normMin, normMax], '', 'c');
 };

test/image/baselines/gl3d_cone-autorange.png

@@ -0,0 +1,28 @@
+{
+  "data": [
+    {
+      "type": "cone",
+      "x": [ 1, 1, 1, 1, 3, 3, 3, 3 ],
+      "y": [ 1, 1, 3, 3, 1, 1, 3, 3 ],
+      "z": [ 1, 3, 1, 3, 1, 3, 1, 3 ],
+      "u": [ 1, 2, 3, 4, 1, 2, 3, 4 ],
+      "v": [ 1, 1, 2, 2, 3, 3, 4, 4 ],
+      "w": [ 4, 4, 1, 1, 2, 2, 3, 3 ],
+      "showscale": false
+    }
+  ],
+  "layout": {
+    "scene": {
+      "camera": {
+        "eye": {
+          "x": -0.009629409001286008,
+          "y": 2.5216768185264913,
+          "z": 0.42700218501677245
+        }
+      }
+    },
+    "width": 500,
+    "height": 500,
+    "margin": {"t": 0, "b": 0, "l": 0, "r": 0}
+  }
+}