surface connectgaps

Author: archmoj

src/traces/surface/attributes.js

@@ -133,6 +133,18 @@ var attrs = module.exports = overrideAll(extendFlat({
     },
     hovertemplate: hovertemplateAttrs(),
 
+    connectgaps: {
+        valType: 'boolean',
+        dflt: false,
+        role: 'info',
+        editType: 'calc',
+        description: [
+            'Determines whether or not gaps',
+            '(i.e. {nan} or missing values)',
+            'in the `z` data are filled in.'
+        ].join(' ')
+    },
+
     surfacecolor: {
         valType: 'data_array',
         description: [

src/traces/surface/convert.js

@@ -19,6 +19,9 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray;
 var parseColorScale = require('../../lib/gl_format_color').parseColorScale;
 var str2RgbaArray = require('../../lib/str2rgbarray');
 
+var interp2d = require('../heatmap/interp2d');
+var findEmpties = require('../heatmap/find_empties');
+
 function SurfaceTrace(scene, surface, uid) {
     this.scene = scene;
     this.uid = uid;
@@ -404,6 +407,11 @@ proto.update = function(data) {
         }
     }
 
+    if(data.connectgaps) {
+        data._emptypoints = findEmpties(rawCoords[2]);
+        interp2d(rawCoords[2], data._emptypoints);
+    }
+
     // Note: log axes are not defined in surfaces yet.
     // but they could be defined here...
 

src/traces/surface/defaults.js

@@ -56,6 +56,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         'lightposition.y',
         'lightposition.z',
         'hidesurface',
+        'connectgaps',
         'opacity'
     ].forEach(function(x) { coerce(x); });
 

test/image/baselines/gl3d_surface_connectgaps.png

@@ -0,0 +1,21 @@
+{
+    "data": [
+      {
+        "type": "surface",
+        "connectgaps": true,
+        "x": [0, 1, 2, 3],
+        "y": [0, 1, 2, 3],
+        "z": [
+          [1, 1, 1, 1],
+          [1, null, 2, null],
+          [1, 1, 1, 1],
+          [1, null, 0, null]
+        ]
+      }
+    ],
+    "layout": {
+        "title": "Surface interpolate gaps",
+        "width": 600,
+        "height": 400
+    }
+}