rename 'layers' cartesian constant -> 'traceLayerClasses'

- which is more meaningul
- other misc lint

Author: etpinard

src/plot_api/subroutines.js

@@ -180,8 +180,8 @@ exports.lsInner = function(gd) {
 
         Drawing.setClipUrl(plotinfo.plot, plotClipId);
 
-        for(i = 0; i < cartesianConstants.layers.length; i++) {
-            var layer = cartesianConstants.layers[i];
+        for(i = 0; i < cartesianConstants.traceLayerClasses.length; i++) {
+            var layer = cartesianConstants.traceLayerClasses[i];
             if(layer !== 'scatterlayer') {
                 plotinfo.plot.selectAll('g.' + layer).call(Drawing.setClipUrl, layerClipId);
             }

src/plots/cartesian/constants.js

@@ -51,14 +51,14 @@ module.exports = {
     DFLTRANGEX: [-1, 6],
     DFLTRANGEY: [-1, 4],
 
-    // Layers to keep plot types in the right order.
+    // Layers to keep trace types in the right order.
     // from back to front:
     // 1. heatmaps, 2D histos and contour maps
     // 2. bars / 1D histos
     // 3. errorbars for bars and scatter
     // 4. scatter
     // 5. box plots
-    layers: [
+    traceLayerClasses: [
         'imagelayer',
         'maplayer',
         'barlayer',

src/plots/cartesian/index.js

@@ -339,8 +339,8 @@ function makeSubplotLayer(plotinfo) {
 
     // common attributes for all subplots, overlays or not
 
-    for(var i = 0; i < constants.layers.length; i++) {
-        joinLayer(plotinfo.plot, 'g', constants.layers[i]);
+    for(var i = 0; i < constants.traceLayerClasses.length; i++) {
+        joinLayer(plotinfo.plot, 'g', constants.traceLayerClasses[i]);
     }
 
     plotinfo.xlines

test/jasmine/tests/scatter_test.js

@@ -675,7 +675,7 @@ describe('scatter hoverPoints', function() {
     });
 });
 
-describe('Test scatter *clipnaxis*', function() {
+describe('Test scatter *clipnaxis*:', function() {
     afterEach(destroyGraphDiv);
 
     it('should show/hide point/text/errorbars in clipped and non-clipped layers', function(done) {
@@ -684,7 +684,7 @@ describe('Test scatter *clipnaxis*', function() {
         var xRange0 = fig.layout.xaxis.range.slice();
         var yRange0 = fig.layout.yaxis.range.slice();
 
-        // only show *cliponaxis: false* trace
+        // only show 1 *cliponaxis: false* trace
         fig.data = [fig.data[2]];
 
         // add lines
@@ -805,5 +805,4 @@ describe('Test scatter *clipnaxis*', function() {
         .catch(fail)
         .then(done);
     });
-
 });