Skip to content

Commit 01e698a

Browse files
committed
Update tests per method change
1 parent 2767f07 commit 01e698a

File tree

1 file changed

+23
-14
lines changed

1 file changed

+23
-14
lines changed

test/jasmine/tests/plot_api_test.js

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3095,44 +3095,53 @@ describe('plot_api helpers', function () {
30953095
});
30963096
});
30973097

3098-
describe('hasCollectionChanged', () => {
3099-
it('Returns true if object collection has changed', () => {
3098+
describe('collectionsAreEqual', () => {
3099+
it('Returns false if object collections are NOT equal', () => {
31003100
expect(
3101-
helpers.hasCollectionChanged(
3101+
helpers.collectionsAreEqual(
31023102
{ captain: 'Leela', deliveryBoy: 'Fry' },
31033103
{ captain: 'Leela', deliveryBoy: 'Bender' }
31043104
)
3105-
).toBe(true);
3105+
).toBe(false);
31063106
});
31073107

3108-
it("Returns false if object collection hasn't changed", () => {
3108+
it('Returns true if object collections are equal', () => {
31093109
expect(
3110-
helpers.hasCollectionChanged(
3110+
helpers.collectionsAreEqual(
31113111
{ captain: 'Leela', deliveryBoy: 'Fry' },
31123112
{ captain: 'Leela', deliveryBoy: 'Fry' }
31133113
)
3114-
).toBe(false);
3114+
).toBe(true);
31153115
});
31163116

3117-
it('Returns true if array collection has changed', () => {
3118-
expect(helpers.hasCollectionChanged(['Zoidberg', 'Hermes'], ['Zoidberg', 'Leela'])).toBe(true);
3117+
it('Returns false if array collections are NOT equal', () => {
3118+
expect(helpers.collectionsAreEqual(['Zoidberg', 'Hermes'], ['Zoidberg', 'Leela'])).toBe(false);
31193119
});
31203120

3121-
it("Returns false if array collection hasn't changed", () => {
3122-
expect(helpers.hasCollectionChanged(['Zoidberg', 'Hermes'], ['Zoidberg', 'Hermes'])).toBe(false);
3121+
it('Returns true if array collection are equal', () => {
3122+
expect(helpers.collectionsAreEqual(['Zoidberg', 'Hermes'], ['Zoidberg', 'Hermes'])).toBe(true);
31233123
});
31243124

31253125
it('Handles nested objects', () => {
31263126
expect(
3127-
helpers.hasCollectionChanged(
3127+
helpers.collectionsAreEqual(
31283128
{ level1: { captain: 'Leela', deliveryBoy: 'Fry' } },
31293129
{ level1: { captain: 'Leela', deliveryBoy: 'Bender' } }
31303130
)
3131-
).toBe(true);
3131+
).toBe(false);
31323132
});
31333133

31343134
it('Handles nested arrays', () => {
3135-
expect(helpers.hasCollectionChanged([['Zoidberg', 'Hermes']], [['Zoidberg', 'Leela']])).toBe(true);
3135+
expect(helpers.collectionsAreEqual([['Zoidberg', 'Hermes']], [['Zoidberg', 'Leela']])).toBe(false);
3136+
});
3137+
3138+
it("Ignores object keys prefixed with '_'", () => {
3139+
expect(
3140+
helpers.collectionsAreEqual(
3141+
{ captain: 'Leela', _deliveryBoy: 'Fry' },
3142+
{ captain: 'Leela', _deliveryBoy: 'Bender' }
3143+
)
3144+
).toBe(true);
31363145
});
31373146
});
31383147
});

0 commit comments

Comments
 (0)