Small tweaks to #1773 (simplify check & add new visual baselines)

Author: cpsievert

R/ggplotly.R

@@ -127,7 +127,7 @@ ggplotly.ggmatrix <- function(p = ggplot2::last_plot(), width = NULL,
                titleY = TRUE, titleX = TRUE) %>% 
     hide_legend() %>%
     layout(dragmode = "select")
-  if (robust_nchar(p$title %||% "") > 0) {
+  if (robust_nchar(p$title) > 0) {
     s <- layout(s, title = p$title)
   }
   for (i in seq_along(p$xAxisLabels)) {
@@ -436,7 +436,7 @@ gg2list <- function(p, width = NULL, height = NULL,
     font = text2font(theme$text)
   )
   # main plot title
-  if (robust_nchar(plot$labels$title %||% "") > 0) {
+  if (robust_nchar(plot$labels$title) > 0) {
     gglayout$title <- list(
       text = faced(plot$labels$title, theme$plot.title$face),
       font = text2font(theme$plot.title),

tests/figs/deps.txt

@@ -1,3 +1,3 @@
 - vdiffr-svg-engine: 1.0
-- vdiffr: 0.3.1
+- vdiffr: 0.3.1.9000
 - freetypeharfbuzz: 0.2.5

tests/figs/labels/factor-labels.svg

@@ -45,12 +45,12 @@ test_that("factor labels work", {
   p <- ggplot(diamonds, aes(cut)) + 
     geom_bar() + 
     scale_x_discrete("Cut", labels=factor(letters[1:5]))
-  plotly_build(p)
+  b <- expect_doppelganger_built(p, "factor-labels")
 })
 
 test_that("empty labels work", {
   p <- ggplot(iris, aes(Petal.Length, Sepal.Width, color = Species)) + 
     geom_point() + 
-    xlab(element_blank()) 
-  plotly_build(p)
+    labs(x = element_blank(), y = element_blank())
+  b <- expect_doppelganger_built(p, "labs-element-blank")
 })