ensure geometry column is a simple features collection before using st_as_sf(), add test that sf works with crosstalk

Author: cpsievert

R/layers2traces.R

@@ -273,7 +273,8 @@ to_basic.GeomRect <- function(data, prestats_data, layout, params, p, ...) {
 #' @export
 to_basic.GeomSf <- function(data, prestats_data, layout, params, p, ...) {
 
-  data <- sf::st_as_sf(data)
+  data[["geometry"]] <- sf::st_sfc(data[["geometry"]])
+  data <- sf::st_as_sf(data, sf_column_name = "geometry")
   geom_type <- sf::st_geometry_type(data)
   # st_cast should "expand" a collection into multiple rows (one per feature)
   if ("GEOMETRYCOLLECTION" %in% geom_type) {

tests/testthat/test-animate-highlight.R

@@ -368,3 +368,21 @@ test_that("animation button can be customized", {
   expect_true(menu$font$color == "white")
   expect_true(menu$buttons[[1]]$label == "Custom")
 })
+
+
+test_that("sf works with crosstalk", {
+  skip_if_not_installed("sf")
+  
+  nc <- sf::st_read(system.file("shape/nc.shp", package = "sf"))
+  # shared data will make the polygons "query-able"
+  ncsd <- SharedData$new(nc)
+  p <- ggplot(ncsd) +
+    geom_sf(aes(fill = AREA, text = paste0(NAME, "\n", "FIPS: ", FIPS))) +
+    ggthemes::theme_map()
+  gg <- ggplotly(p, tooltip = "text")
+  d <- gg$x$data
+  for (i in seq_along(d)) {
+    expect_false(is.null(d[[i]]$key))
+    expect_false(is.null(d[[i]]$set))
+  }
+})