Ensure marker.sizemode is always respected, closes #1133, closes #1198

Author: cpsievert

R/utils.R

@@ -496,6 +496,13 @@ verify_attr <- function(proposed, schema) {
       proposed$name <- uniq(proposed$name)
     }
 
+    # if marker.sizemode='area', make sure marker.size is boxed up 
+    # (otherwise, when marker.size is a constant, it always sets the diameter!)
+    # https://codepen.io/cpsievert/pen/zazXgw
+    if ("area" %in% proposed$marker$sizemode) {
+      proposed$marker[["size"]] <- i(proposed$marker[["size"]])
+    }
+    
     # do the same for "sub-attributes"
     if (identical(role, "object")) {
       proposed[[attr]] <- verify_attr(proposed[[attr]], schema[[attr]])

tests/testthat/test-plotly-size.R

@@ -0,0 +1,20 @@
+context("size")
+
+test_that("sizemode is always respected", {
+  
+  # https://github.com/ropensci/plotly/issues/1133
+  p <- plot_ly(mtcars, x = ~wt, y = ~wt, size = ~wt, color = ~as.factor(carb)) 
+  d <- plotly_build(p)$x$data
+  expect_length(d, length(unique(mtcars$carb)))
+  
+  for (i in seq_along(d)) {
+    expect_true(d[[i]]$type == "scatter")
+    expect_true(d[[i]]$mode == "markers")
+    expect_true(d[[i]]$marker$sizemode == "area")
+    # Make sure size is always translated as an array in this case, because plotly.js
+    # https://github.com/plotly/plotly.js/issues/2735
+    s <- d[[i]]$marker$size
+    if (length(s) == 1) expect_is(s, "AsIs")
+  }
+  
+})