throw warning if cloud is specified; add tests

Author: cpsievert

R/layout.R

@@ -159,7 +159,7 @@ config <- function(p, ..., cloud = FALSE, showSendToCloud = cloud, locale = NULL
   args <- list(...)
   if ("collaborate" %in% names(args)) warning("The collaborate button is no longer supported")
   p$x$config <- modify_list(p$x$config, args)
-  if (cloud) message("The `cloud` argument is deprecated. Use `showSendToCloud` instead.")
+  if (cloud) warning("The `cloud` argument is deprecated. Use `showSendToCloud` instead.")
   p$x$config$showSendToCloud <- showSendToCloud
 
   p

tests/testthat/test-plotly.R

@@ -295,3 +295,18 @@ test_that("Axis domains aren't supplied if layout.grid exists", {
   expect_null(l$layout$xaxis$domain)
   expect_null(l$layout$yaxis$domain)
 })
+
+
+test_that("Informative deprecation message for titlefont", {
+  expect_warning(config(plot_ly(), cloud = TRUE), "cloud")
+})
+
+test_that("Informative warning for invalid config attr", {
+  p <- config(plot_ly(), foobar = TRUE)
+  expect_warning(plotly_build(p), "foobar")
+})
+
+test_that("Informative deprecation message for titlefont", {
+  p <- layout(plot_ly(), title = "A title", titlefont = list(size = 30))
+  expect_warning(plotly_build(p), "titlefont")
+})