dont srcify layout attributes

Author: michaelbabyn

R/utils.R

@@ -444,7 +444,7 @@ verify_attr_names <- function(p) {
 verify_attr_spec <- function(p) {
   if (!is.null(p$x$layout)) {
     p$x$layout <- verify_attr(
-      p$x$layout, Schema$layout$layoutAttributes
+      p$x$layout, Schema$layout$layoutAttributes, layoutAttr = TRUE
     )
   }
   for (tr in seq_along(p$x$data)) {
@@ -459,7 +459,7 @@ verify_attr_spec <- function(p) {
   p
 }
 
-verify_attr <- function(proposed, schema) {
+verify_attr <- function(proposed, schema, layoutAttr = FALSE) {
   for (attr in names(proposed)) {
     attrSchema <- schema[[attr]] %||% schema[[sub("[0-9]+$", "", attr)]]
     # if schema is missing (i.e., this is an un-official attr), move along
@@ -489,7 +489,7 @@ verify_attr <- function(proposed, schema) {
 
     # tag 'src-able' attributes (needed for api_create())
     isSrcAble <- !is.null(schema[[paste0(attr, "src")]]) && length(proposed[[attr]]) > 1
-    if (isDataArray || isSrcAble) {
+    if ((isDataArray || isSrcAble) && !isTRUE(layoutAttr)) {
       proposed[[attr]] <- structure(proposed[[attr]], apiSrc = TRUE)
     }
 
@@ -517,7 +517,7 @@ verify_attr <- function(proposed, schema) {
 
     # do the same for "sub-attributes"
     if (identical(role, "object") && is.recursive(proposed[[attr]])) {
-      proposed[[attr]] <- verify_attr(proposed[[attr]], schema[[attr]])
+      proposed[[attr]] <- verify_attr(proposed[[attr]], schema[[attr]], layoutAttr = layoutAttr)
     }
   }
 

tests/testthat/test-api.R

@@ -118,6 +118,10 @@
 #     expect_length(strsplit(x, ":")[[1]], 3)
 #   }
 #   
+#   expect_not_srcified <- function(x) {
+#     expect_true(is.null(x))
+#   }
+# 
 #   # src-ifies data arrays, but not arrayOk of length 1
 #   p <- plot_ly(x = 1:10, y = 1:10, marker = list(color = "red")) 
 #   res <- api_create(p)
@@ -138,9 +142,9 @@
 #     api_create()
 #   trace <- res$figure$frames[[1]]$data[[1]]
 #   expect_srcified(trace$marker$colorsrc)
-#   
-#   # can src-ify layout.xaxis.tickvals
+# 
+#   # doesn't src-ify layout arrays (layout.xaxis.tickvals)
 #   res <- api_create(ggplot() + geom_bar(aes(1:10)))
-#   expect_srcified(res$figure$layout$xaxis$tickvalssrc)
-#   
+#   expect_not_srcified(res$figure$layout$xaxis$tickvalssrc)
+# 
 # })