Remove "string" as possible option for some props

Author: KoolADE85

components/dash-core-components/src/components/Textarea.tsx

@@ -6,6 +6,12 @@ import './css/textarea.css';
 
 const textAreaProps = [
     'id',
+    'cols',
+    'rows',
+    'minLength',
+    'maxLength',
+    'contentEditable',
+    'tabIndex',
     'form',
     'name',
     'placeholder',
@@ -20,26 +26,6 @@ const textAreaProps = [
     'title',
 ] as const;
 
-const asNumber = (value?: string | number): number | undefined => {
-    return typeof value === 'string'
-        ? isNaN(parseInt(value, 10))
-            ? undefined
-            : parseInt(value, 10)
-        : value;
-};
-const asBool = (value?: string | boolean): boolean | undefined => {
-    if (typeof value === 'string') {
-        if (['true', 'TRUE', 'True'].includes(value)) {
-            return true;
-        }
-        if (['false', 'FALSE', 'False'].includes(value)) {
-            return false;
-        }
-        return undefined;
-    }
-    return value;
-};
-
 /**
  * A basic HTML textarea for entering multiline text.
  *
@@ -60,17 +46,11 @@ const Textarea = ({
             data-dash-is-loading={isLoading || undefined}
             className={'dash-textarea ' + props.className}
             value={props.value}
-            cols={asNumber(props.cols)}
-            rows={asNumber(props.rows)}
-            disabled={asBool(props.disabled)}
-            minLength={asNumber(props.minLength)}
-            maxLength={asNumber(props.maxLength)}
-            readOnly={asBool(props.readOnly)}
-            required={asBool(props.required)}
-            autoFocus={asBool(props.autoFocus)}
-            contentEditable={asBool(props.contentEditable)}
-            hidden={asBool(props.hidden)}
-            tabIndex={asNumber(props.tabIndex)}
+            disabled={!!props.disabled}
+            readOnly={!!props.readOnly}
+            required={!!props.required}
+            autoFocus={!!props.autoFocus}
+            hidden={!!props.hidden}
             onChange={e => {
                 setProps({value: e.target.value});
             }}

components/dash-core-components/src/types.ts

@@ -533,12 +533,12 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Defines the number of columns in a textarea.
      */
-    cols?: string | number;
+    cols?: number;
 
     /**
      * Indicates whether the user can interact with the element.
      */
-    disabled?: string | boolean;
+    disabled?: boolean | 'disabled' | 'DISABLED';
 
     /**
      * Indicates the form that is the owner of the element.
@@ -548,12 +548,12 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Defines the maximum number of characters allowed in the element.
      */
-    maxLength?: string | number;
+    maxLength?: number;
 
     /**
      * Defines the minimum number of characters allowed in the element.
      */
-    minLength?: string | number;
+    minLength?: number;
 
     /**
      * Name of the element. For example used by the server to identify the fields in form submits.
@@ -584,7 +584,7 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Defines the number of rows in a text area.
      */
-    rows?: string | number;
+    rows?: number;
 
     /**
      * Indicates whether the text should be wrapped.
@@ -599,7 +599,7 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Indicates whether the element's content is editable.
      */
-    contentEditable?: string | boolean;
+    contentEditable?: boolean;
 
     /**
      * Defines the ID of a <menu> element which will serve as the element's context menu.
@@ -614,7 +614,7 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Defines whether the element can be dragged.
      */
-    draggable?: boolean | 'true' | 'false';
+    draggable?: boolean;
 
     /**
      * Prevents rendering of given element, while keeping child elements, e.g. script elements, active.
@@ -629,7 +629,7 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Indicates whether spell checking is allowed for the element.
      */
-    spellCheck?: boolean | 'true' | 'false';
+    spellCheck?: boolean;
 
     /**
      * Defines CSS styles which will override styles previously set.
@@ -639,7 +639,7 @@ export interface TextAreaProps extends BaseComponentProps<TextAreaProps> {
     /**
      * Overrides the browser's default tab order and follows the one specified instead.
      */
-    tabIndex?: string | number;
+    tabIndex?: number;
 
     /**
      * Text to be displayed in a tooltip when hovering over the element.