Merge branch 'main' into andrew/further-thread-extraction

Author: ayjayt

.github/workflows/ruff.yml

@@ -8,4 +8,4 @@ jobs:
       - uses: actions/checkout@v4
       - uses: astral-sh/ruff-action@v3
         with:
-          src: 'choreographer'
+          src: 'src'

.pre-commit-config.yaml

@@ -18,12 +18,12 @@ repos:
       - id: check-toml
       - id: debug-statements
   - repo: https://github.com/asottile/add-trailing-comma
-    rev: v3.2.0
+    rev: v4.0.0
     hooks:
       - id: add-trailing-comma
   - repo: https://github.com/astral-sh/ruff-pre-commit
     #  Ruff version.
-    rev: v0.13.3
+    rev: v0.14.4
     hooks:
       #  Run the linter.
       - id: ruff
@@ -48,7 +48,7 @@ repos:
           }\
         }"]
   - repo: https://github.com/rhysd/actionlint
-    rev: v1.7.7
+    rev: v1.7.8
     hooks:
       - id: actionlint
         name: Lint GitHub Actions workflow files
@@ -81,14 +81,14 @@ repos:
         entry: detect-secrets-hook
         args: ['']
   - repo: https://github.com/rvben/rumdl-pre-commit
-    rev: v0.0.153  # Use the latest release tag
+    rev: v0.0.173  # Use the latest release tag
     hooks:
       - id: rumdl
         # To only check (default):
         # args: []
         # To automatically fix issues:
         # args: [--fix]
   - repo: https://github.com/RobertCraigie/pyright-python
-    rev: v1.1.406   # pin a tag; latest as of 2025-10-01
+    rev: v1.1.407   # pin a tag; latest as of 2025-10-01
     hooks:
       - id: pyright

CHANGELOG.txt

@@ -5,6 +5,12 @@ v1.2.1
   upon at all. We use a custom threadpool during `Browser.close()` so that it
   can be leveraged during atexit, and now we use it during `Browser.open()`
   since certain use patterns have that function running during shutdown.
+- Remove site directory
+- Improve error messaging
+- Organize functions internally
+- Improve choreo_diagnose
+- Add Roadmap
+- Bump logistro dependency
 v1.2.0
 - Delete zipfile after downloading
 - Upgrade logistro to reduce sideeffects

ROADMAP.md

@@ -0,0 +1,17 @@
+# Roadmap
+
+- [ ] Working on better diagnostic information
+  - [ ] Explain to user when their system has security restrictions
+- [ ] Eliminate synchronous API: it's unused, hard to maintain, and nearly
+worthless
+- [ ] Diagnose function should collect a JSON and then print that
+- [ ] Allow user to build and send their own JSONS
+  - [ ] Get serialization out of the lock
+- [ ]
+- [ ] Support Firefox
+- [ ] Support LadyBird (!)
+- [ ] Test against multiple docker containers
+- [ ] Do browser-rolling tests
+- [ ] Do documentation
+- [ ] Browser Open/Close Status/PipeCheck status should happen at broker level
+  - [ ] Broker should probably be opening browser and running watchdog...

pyproject.toml

@@ -2,8 +2,11 @@
 requires = ["setuptools>=65.0.0", "wheel", "setuptools-git-versioning"]
 build-backend = "setuptools.build_meta"
 
-[tool.setuptools.packages]
-find = {namespaces = true}
+[tool.setuptools]
+
+[tool.setuptools.packages.find]
+where = ["src"]
+namespaces = false
 
 [tool.setuptools-git-versioning]
 enabled = true
@@ -26,7 +29,7 @@ maintainers = [
   {name = "Andrew Pikul", email = "ajpikul@gmail.com"},
 ]
 dependencies = [
-  "logistro>=2.0.0",
+  "logistro>=2.0.1",
   "simplejson>=3.19.3",
 ]
 
@@ -69,7 +72,7 @@ dev = [
 #logistro = { path = "../logistro", editable = true }
 
 [tool.ruff]
-src = ["choreographer"]
+src = ["src"]
 
 [tool.ruff.lint]
 select = ["ALL"]
@@ -126,4 +129,4 @@ help = "Run any/all tests one by one with basic settings: can include filename a
 [tool.pyright]
 venvPath = "."
 venv = ".venv"
-include = ["choreographer", "tests"]
+include = ["src", "tests"]