Removing plotly-via-window.module

Author: afarzat-ed

README.md

@@ -29,7 +29,6 @@ Supports Angular 9.x and up. If you want to use with Angular 8.x, please use ver
   * [Event handler props](#event-handler-props)
 * [Customizing the `plotly.js` bundle](#customizing-the-plotlyjs-bundle)
   * [Plotly Via CDN Module](#plotly-via-cdn-module)
-  * [Plotly Via Window Module](#plotly-via-window-module)
 * [Development](#development)
 
 ## Installation
@@ -190,7 +189,7 @@ in front of any plotly-generated elements. This could be useful for implementing
 
 By default, this library bundles `plotly.js` from the peer dependency together within the output. This results on huge outputs, for `plotly.js` itself is ~3MB when bundled. It also makes the build (with `ng serve --prod`) really slow, for it minifies everything together.
 
-If you wish to optimize loading `plotly.js` in a different way, please check both [`PlotlyViaCDNModule`](#plotly-via-cdn-module) and [`PlotlyViaWindowModule`](#plotly-via-window-module) modules below.
+If you wish to optimize loading `plotly.js` in a different way, please check the [`PlotlyViaCDNModule`](#plotly-via-cdn-module) module below.
 
 
 ### Plotly Via CDN Module
@@ -232,50 +231,6 @@ PlotlyViaCDNModule.loadViaCDN('custom', 'https://custom.cdn/url'); // can be use
 ...
 ```
 
-### Plotly Via Window Module
-
-`plotly.js` can be added as a [global script on angular.json](https://github.com/angular/angular-cli/wiki/stories-global-scripts#global-scripts) to avoid it being bundled into the final project's code. To make this happen, you must first add `plotly.js` path into `angular.json` file as shown below:
-
-```javascript
-// angular.json
-{
-    ...
-    "projects": {
-        "project-name": { // This is your project's name
-            ...
-            "architect": {
-                "build": {
-                    ...
-                    "options": {
-                        "scripts": [
-                            "node_modules/plotly.js-dist-min/plotly.min.js" // add this
-                        ]
-                    }
-                }
-            }
-            ...
-        }
-    }
-}
-```
-
-This will include `plotly.js` into the `vendor.js` file generated by angular CLI build process, and `plotly.js` library will be loaded before angular and your project's code. The `window.Plotly` will be available. Thus, you must use `PlotlyViaWindowModule` module to force `angular-plotly.js` to use `window.Plotly` object:
-
-
-```typescript
-import { NgModule } from '@angular/core';
-import { CommonModule } from '@angular/common';
-
-import { PlotlyViaWindowModule } from 'angular-plotly.js';
-
-@NgModule({
-    imports: [CommonModule, PlotlyViaWindowModule],
-    ...
-})
-export class AppModule { }
-```
-
-If you want to use a [different precompiled bundle](https://github.com/plotly/plotly.js/blob/master/dist/README.md#partial-bundles) or if you wish to [assemble you own customized bundle](https://github.com/plotly/plotly.js#modules), you can use `PlotlyViaWindowModule` to force the use of `window.Plotly` object as shown above.
 
 ## Development
 

projects/demo_app/src/app/app.module.ts

@@ -2,7 +2,6 @@ import { NgModule } from '@angular/core';
 import { BrowserModule } from '@angular/platform-browser';
 
 
-import { PlotlyViaWindowModule } from 'projects/plotly/src/lib/plotly-via-window.module';
 
 import { AppComponent } from './app.component';
 
@@ -12,7 +11,6 @@ import { AppComponent } from './app.component';
   ],
   imports: [
     BrowserModule,
-    PlotlyViaWindowModule
   ],
   providers: [],
   bootstrap: [AppComponent]

projects/plotly/src/lib/plotly-via-window.module.ts

@@ -4,7 +4,6 @@
 
 export * from './lib/plotly.module';
 export * from './lib/plotly-via-cdn.module';
-export * from './lib/plotly-via-window.module';
 export * from './lib/plotly-shared.module';
 
 export * from './lib/plotly.service';