Reduce amount of code duplication for "get" operations.

Author: sibprogrammer

src/PleskX/Api/Operator.php

@@ -57,4 +57,33 @@ protected function _delete($field, $value, $deleteMethodName = 'del')
         return 'ok' === (string)$response->status;
     }
 
+    /**
+     * @param string $structClass
+     * @param string $infoTag
+     * @param string|null $field
+     * @param integer|string|null $value
+     * @return mixed
+     */
+    protected function _getItems($structClass, $infoTag, $field = null, $value = null)
+    {
+        $packet = $this->_client->getPacket();
+        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get');
+
+        $filterTag = $getTag->addChild('filter');
+        if (!is_null($field)) {
+            $filterTag->addChild($field, $value);
+        }
+
+        $getTag->addChild('dataset')->addChild($infoTag);
+
+        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
+
+        $items = [];
+        foreach ($response->xpath('//result') as $xmlResult) {
+            $items[] = new $structClass($xmlResult->data->$infoTag);
+        }
+
+        return $items;
+    }
+
 }

src/PleskX/Api/Operator/Customer.php

@@ -41,7 +41,7 @@ public function delete($field, $value)
      */
     public function get($field, $value)
     {
-        $items = $this->_get($field, $value);
+        $items = $this->_getItems(Struct\GeneralInfo::class, 'gen_info', $field, $value);
         return reset($items);
     }
 
@@ -50,34 +50,7 @@ public function get($field, $value)
      */
     public function getAll()
     {
-        return $this->_get();
-    }
-
-    /**
-     * @param string|null $field
-     * @param integer|string|null $value
-     * @return Struct\GeneralInfo|Struct\GeneralInfo[]
-     */
-    private function _get($field = null, $value = null)
-    {
-        $packet = $this->_client->getPacket();
-        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get');
-
-        $filterTag = $getTag->addChild('filter');
-        if (!is_null($field)) {
-            $filterTag->addChild($field, $value);
-        }
-
-        $getTag->addChild('dataset')->addChild('gen_info');
-
-        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
-
-        $customers = [];
-        foreach ($response->xpath('//result') as $xmlResult) {
-            $customers[] = new Struct\GeneralInfo($xmlResult->data->gen_info);
-        }
-
-        return $customers;
+        return $this->_getItems(Struct\GeneralInfo::class, 'gen_info');
     }
 
 }

src/PleskX/Api/Operator/Reseller.php

@@ -34,19 +34,26 @@ public function delete($field, $value)
         return $this->_delete($field, $value);
     }
 
+
     /**
      * @param string $field
      * @param integer|string $value
      * @return Struct\GeneralInfo
      */
     public function get($field, $value)
     {
-        $packet = $this->_client->getPacket();
-        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get');
-        $getTag->addChild('filter')->addChild($field, $value);
-        $getTag->addChild('dataset')->addChild('gen-info');
-        $response = $this->_client->request($packet);
-        return new Struct\GeneralInfo($response->data->{'gen-info'});
+        $items = $this->_getItems(Struct\GeneralInfo::class, 'gen-info', $field, $value);
+        return reset($items);
+    }
+
+    /**
+     * @return Struct\GeneralInfo[]
+     */
+    public function getAll()
+    {
+        return $this->_getItems(Struct\GeneralInfo::class, 'gen-info');
     }
 
+
+
 }

src/PleskX/Api/Operator/Site.php

@@ -42,35 +42,16 @@ public function delete($field, $value)
      */
     public function get($field, $value)
     {
-        $items = $this->getAll($field, $value);
+        $items = $this->_getItems(Struct\GeneralInfo::class, 'gen_info', $field, $value);
         return reset($items);
     }
 
     /**
-     * @param string $field
-     * @param integer|string $value
      * @return Struct\GeneralInfo[]
      */
-    public function getAll($field = null, $value = null)
+    public function getAll()
     {
-        $packet = $this->_client->getPacket();
-        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get');
-
-        $filterTag = $getTag->addChild('filter');
-        if (!is_null($field)) {
-            $filterTag->addChild($field, $value);
-        }
-
-        $getTag->addChild('dataset')->addChild('gen_info');
-
-        $response = $this->_client->request($packet, \PleskX\Api\Client::RESPONSE_FULL);
-
-        $items = [];
-        foreach ($response->xpath('//result') as $xmlResult) {
-            $items[] = new Struct\GeneralInfo($xmlResult->data->gen_info);
-        }
-
-        return $items;
+        return $this->_getItems(Struct\GeneralInfo::class, 'gen_info');
     }
 
 }

src/PleskX/Api/Operator/Webspace.php

@@ -74,12 +74,16 @@ public function delete($field, $value)
      */
     public function get($field, $value)
     {
-        $packet = $this->_client->getPacket();
-        $getTag = $packet->addChild($this->_wrapperTag)->addChild('get');
-        $getTag->addChild('filter')->addChild($field, $value);
-        $getTag->addChild('dataset')->addChild('gen_info');
-        $response = $this->_client->request($packet);
-        return new Struct\GeneralInfo($response->data->gen_info);
+        $items = $this->_getItems(Struct\GeneralInfo::class, 'gen_info', $field, $value);
+        return reset($items);
+    }
+
+    /**
+     * @return Struct\GeneralInfo[]
+     */
+    public function getAll()
+    {
+        return $this->_getItems(Struct\GeneralInfo::class, 'gen_info');
     }
 
 }