fix(pklGeneration): Handle resolvables correctly for AWS::IAM:RolePolicy RoleName and improve unmanaged stack rendering #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When extracting resources with resolvable references, the PKL generator encountered two issues:
Type mismatch error: Resources with resolvable properties (e.g.,
AWS::IAM::RolePolicywithRoleName) failed during extraction with error:This occurred because resolvable values were being passed as
Dynamicbut inrolepolicy.pklit was implemented asroleName: Stringwhich doesn't allow Resovable.Unmanaged stack rendering: Resolvables referencing unmanaged resources were rendered as full resolvable objects, which would fail during PKL evaluation since the referenced stack doesn't exist yet and it wouldn't change the stack of the Resolvable.
Solution
1. Add
formae.Resolvableto RoleName of rolepolicy: This allows the generation of aResolvablefor this property.2. Improved unmanaged stack rendering
$unmanaged): Renders as a string value with an inline commentTesting
Before:
After: