feat(tag-builder): translate rails enum values

In display text and also interactive select options

Author: difernandez

lib/activeadmin_addons/addons/tag_builder.rb

@@ -25,9 +25,9 @@ def select_tag
 
         context.div(interactive_tag_select_params) do
           context.select do
-            possible_values.each do |val|
-              context.option(value: val, selected: val == data) do
-                context.text_node val.capitalize
+            possible_values.each do |label, value|
+              context.option(value: value, selected: value == data) do
+                context.text_node label
               end
             end
           end
@@ -36,7 +36,11 @@ def select_tag
     end
 
     def display_data
-      @enum_attr == :enumerize ? data.text : data
+      if @enum_attr == :enumerize
+        data.text
+      else
+        EnumUtils.translate_enum_option(model.class, attribute.to_s, data)
+      end
     end
 
     def interactive_params(klass)
@@ -69,9 +73,9 @@ def interactive_tag_select_params
     def possible_values
       klass = model.class
       if @enum_attr == :enumerize
-        klass.enumerized_attributes[attribute.to_s].values
+        klass.enumerized_attributes[attribute.to_s].values.map { |value| [value.capitalize, value] }
       else
-        klass.defined_enums[attribute.to_s].keys
+        EnumUtils.options_for_select(klass, attribute.to_s)
       end
     end
 

spec/dummy/config/locales/en.yml

@@ -20,6 +20,9 @@ en:
     attributes:
       invoice:
         item_ids: Items
+        statuses:
+          active: Activo
+          archived: Archivado
   activeadmin:
     addons:
       boolean:

spec/features/tag_builder_spec.rb

@@ -102,22 +102,7 @@
   end
 
   context "using Rails Enum" do
-    context "changing state value" do
-      before do
-        register_index(Invoice) do
-          tag_column :status
-        end
-
-        create_invoice(status: :archived)
-        visit admin_invoices_path
-      end
-
-      it "shows set value" do
-        expect(page).to have_css('.archived')
-      end
-    end
-
-    context 'with interactive option' do
+    shared_examples 'interactive select rendering' do
       let!(:invoice) { create_invoice(status: :active) }
 
       before do
@@ -161,5 +146,71 @@
         expect(page).to have_css('.interactive-tag-select[data-value="active"]')
       end
     end
+
+    context 'with no translations' do
+      around do |example|
+        I18n.with_locale('de') do
+          example.run
+        end
+      end
+
+      context "without interactive option" do
+        before do
+          register_index(Invoice) do
+            tag_column :status
+          end
+
+          create_invoice(status: :archived)
+          visit admin_invoices_path
+        end
+
+        it "shows untranslated text as value" do
+          expect(page.find('td.col-status').text).to eq('Archived')
+        end
+      end
+
+      context 'with interactive option' do
+        include_examples 'interactive select rendering'
+
+        it 'renders an option for each enum value, with translated text' do
+          option_selector = '.interactive-tag-select option'
+          expect(page.find("#{option_selector}[value='active']").text).to eq('active')
+          expect(page.find("#{option_selector}[value='archived']").text).to eq('archived')
+        end
+      end
+    end
+
+    context 'with translations' do
+      around do |example|
+        I18n.with_locale('en') do
+          example.run
+        end
+      end
+
+      context "without interactive option" do
+        before do
+          register_index(Invoice) do
+            tag_column :status
+          end
+
+          create_invoice(status: :archived)
+          visit admin_invoices_path
+        end
+
+        it "shows translated text as value" do
+          expect(page.find('td.col-status').text).to eq('Archivado')
+        end
+      end
+
+      context 'with interactive option' do
+        include_examples 'interactive select rendering'
+
+        it 'renders an option for each enum value, with translated text' do
+          option_selector = '.interactive-tag-select option'
+          expect(page.find("#{option_selector}[value='active']").text).to eq('Activo')
+          expect(page.find("#{option_selector}[value='archived']").text).to eq('Archivado')
+        end
+      end
+    end
   end
 end