Skip to content

Commit 70b117e

Browse files
authored
Minor README wording tweaks
1 parent a182da8 commit 70b117e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,12 @@ Source: [blog.dbrgn.ch](https://blog.dbrgn.ch/2013/10/4/heroku-schedule-weekly-m
129129
Suggestions and pull requests are welcome in improving the situation with the
130130
following security considerations:
131131

132-
- When configuring this gem you are baking a non-expiring Heroku API token
133-
into your applications environment. Your collaborators could use this
132+
- When configuring this gem you must add a non-expiring Heroku API token
133+
into your application environment. Your collaborators could use this
134134
token to impersonate the account it was created with when accessing
135135
the Heroku API. This is important if your account has access to other apps
136-
that your collaborators don’t. Additionally, if your application’s environment was
137-
leaked this would give access to the Heroku API as your user account.
136+
that your collaborators don’t. Additionally, if your application environment was
137+
leaked this would give the attacker access to the Heroku API as your user account.
138138
[More information about Heroku’s API and oAuth](https://devcenter.heroku.com/articles/oauth#direct-authorization).
139139

140140
You should create the API token from a suitably locked-down account.
@@ -153,7 +153,7 @@ following security considerations:
153153
we don’t register with LetsEncrypt over and over.
154154

155155
- Stop using a fork of the `platform-api` gem once it supports the SNI endpoint
156-
API calls.
156+
API calls. [See issue #49 of the platform-api gem](https://github.com/heroku/platform-api/issues/49).
157157

158158
- Provide instructions for running the gem decoupled from the app it is
159159
securing, for the paranoid.

0 commit comments

Comments
 (0)