Merge pull request #56 from rmNULL/master

exit 1  on failure to create NOTES_DIRECTORY

Author: pimterry

notes

@@ -13,8 +13,9 @@ notes_dir="${configured_dir:-$HOME/notes}"
 escaped_notes_dir="$(printf "$notes_dir" | sed -e 's/[]\/$*.^|[]/\\&/g')"
 
 # Make sure the notes directory actually exists, and create it if it doesn't
-if [ ! -d "$notes_dir" ]; then
-    mkdir -p "$notes_dir"
+if ! $(mkdir -p "$notes_dir"); then
+    echo "Could not create directory $notes_dir, please update your \$NOTES_DIRECTORY" >&2
+    exit 1
 fi
 
 # If no $EDITOR, look for `editor` (symlink on debian/ubuntu/etc)

test/test-config.bats

@@ -42,3 +42,21 @@ notes="./notes"
   assert_success
   assert_exists "$NOTES_DIRECTORY/test.txt"
 }
+
+@test "Configuration should be accepted if NOTES_DIR doesn't exist" {
+  mkdir -p $HOME/.config/notes
+  echo "NOTES_DIRECTORY=$NOTES_DIRECTORY/notesdir" > $HOME/.config/notes/config
+  run $notes new test
+
+  assert_success
+}
+
+@test "Configuration should be rejected if NOTES_DIR is a existing file" {
+  mkdir -p $HOME/.config/notes
+  touch $NOTES_DIRECTORY/testfile
+  echo "NOTES_DIRECTORY=$NOTES_DIRECTORY/testfile" > $HOME/.config/notes/config
+  run $notes new test
+
+  assert_failure
+  assert_line "Could not create directory $NOTES_DIRECTORY/testfile, please update your \$NOTES_DIRECTORY"
+}