remove renewals from secret store interface

Author: Southclaws

service/secret/memory/memory.go

@@ -1,8 +1,6 @@
 package memory
 
 import (
-	"context"
-
 	"github.com/picostack/picobot/service/secret"
 )
 
@@ -17,8 +15,3 @@ var _ secret.Store = &MemorySecrets{}
 func (v *MemorySecrets) GetSecretsForTarget(name string) (map[string]string, error) {
 	return v.Secrets, nil
 }
-
-// Renew implements secret.Store
-func (v *MemorySecrets) Renew(ctx context.Context) error {
-	return nil
-}

service/secret/secret.go

@@ -1,9 +1,6 @@
 package secret
 
-import "context"
-
 // Store describes a type that can securely obtain secrets for services.
 type Store interface {
 	GetSecretsForTarget(name string) (map[string]string, error)
-	Renew(ctx context.Context) error
 }

service/service.go

@@ -85,10 +85,12 @@ func (app *App) Start(ctx context.Context) error {
 
 	g.Go(app.watcher.Start)
 
-	g.Go(func() error {
-		return retrier.New(retrier.ConstantBackoff(3, 100*time.Millisecond), nil).
-			RunCtx(ctx, app.secrets.Renew)
-	})
+	if s, ok := app.secrets.(*vault.VaultSecrets); ok {
+		g.Go(func() error {
+			return retrier.New(retrier.ConstantBackoff(3, 100*time.Millisecond), nil).
+				RunCtx(ctx, s.Renew)
+		})
+	}
 
 	return g.Wait()
 }