Fix invalid cell width calculation with modern unicode-width versions #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! Could wee add a quick test so we ensure it doesn't break anymore after? |
Author
|
Done |
Author
|
@pinkforest, could you please merge the PR and bump version? |
pinkforest
reviewed
Jan 11, 2025
| lazy_static = "1.4" | ||
| is-terminal = "0.4" | ||
| encode_unicode = "1.0" | ||
| strip-ansi-escapes = "0.2" |
Collaborator
There was a problem hiding this comment.
Do we know the MSRV of this and it's dependencies?
Author
There was a problem hiding this comment.
No, but it's 1.5 years old, so it's definitely small enough to not bother.
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Dec 1, 2025
Summary: The unicode-width crate was pinned to a specific version in D64960800 to solve an issue with prettytable-rs. The prettytable-rs crate has not been updated in a couple of years. I published a branch on GitHub that contains prettytable-rs 0.10.0 + a fix for the bug that lead to the pinning in phsym/prettytable-rs#170. Shipping this should enable unpinning unicode-width. I am interested in this, because it's blocking an import I am trying to do. Note: it looks like projects in the Rust ecosystem are moving to the comfy-table crate as a replacement for prettytable-rs. I might have a poke at this too. Reviewed By: dtolnay Differential Revision: D88012122 fbshipit-source-id: 26d1caa67472c45a1480471b0745087301c58b1c
meta-codesync bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Dec 1, 2025
Summary: The unicode-width crate was pinned to a specific version in D64960800 to solve an issue with prettytable-rs. The prettytable-rs crate has not been updated in a couple of years. I published a branch on GitHub that contains prettytable-rs 0.10.0 + a fix for the bug that lead to the pinning in phsym/prettytable-rs#170. Shipping this should enable unpinning unicode-width. I am interested in this, because it's blocking an import I am trying to do. Note: it looks like projects in the Rust ecosystem are moving to the comfy-table crate as a replacement for prettytable-rs. I might have a poke at this too. Reviewed By: dtolnay Differential Revision: D88012122 fbshipit-source-id: 26d1caa67472c45a1480471b0745087301c58b1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165