fix array short syntax for php 5.3

Author: Nabeel Shahzad

Makefile

@@ -0,0 +1,16 @@
+#
+#
+#
+
+.PHONY: install-cs
+install-cs:
+	composer global require "squizlabs/php_codesniffer=*"
+	composer global require "wimg/php-compatibility=*"
+	phpcs --config-set installed_paths ~/.composer/vendor/wimg/php-compatibility
+
+.PHONY: run-cs
+run-cs-53:
+	phpcs -p . --standard=PHPCompatibility --warning-severity=0  --runtime-set testVersion 5.3
+
+run-cs-70:
+	phpcs -p . --standard=PHPCompatibility --warning-severity=0 --runtime-set testVersion 7.0- 

core/classes/CodonData.class.php

@@ -62,6 +62,6 @@ public function firephp()
 		include_once CORE_PATH.DS.'lib'.DS.'firebug'.DS.'FirePHP.class.php';
 
 		$instance = FirePHP::getInstance(true);
-		return call_user_func_array([$instance, 'fb'], func_get_args());
+		return call_user_func_array(array($instance, 'fb'), func_get_args());
 	}
 }

core/classes/CodonWebService.class.php

@@ -40,8 +40,8 @@
 class CodonWebService
 {
 
-    public $options = [];
-    public $errors = [];
+    public $options = array();
+    public $errors = array();
 
     protected $type = 'curl';
     protected $curl = null;
@@ -61,14 +61,14 @@ public function __construct()
         }
 
         $this->setType('curl');
-        $this->setOptions([
+        $this->setOptions(array(
             CURLOPT_FOLLOWLOCATION => true,
             CURLOPT_RETURNTRANSFER => true,
             CURLOPT_AUTOREFERER => true,
             CURLOPT_CONNECTTIMEOUT => 30,
             CURLOPT_HEADER => false,
             CURLOPT_FOLLOWLOCATION => true,
-        ]);
+        ));
     }
 
     public function __destruct()
@@ -146,7 +146,7 @@ public function getSSL($url, $params, $type = 'get')
      * @param array $params Associative array of key=value
      * @return string
      */
-    public function get($url, $params = [])
+    public function get($url, $params = array())
     {
         # Builds the parameters list
         if (is_array($params)) {
@@ -182,7 +182,7 @@ public function get($url, $params = [])
      * @param array $params Associative array of key=value
      * @return bool
      */
-    public function post($url, $params = [])
+    public function post($url, $params = array())
     {
         if (!$this->curl) {
             $this->error('cURL not initialized');

install/Installer.class.php

@@ -25,7 +25,7 @@ public static function CheckServer()
     {
         $noerror = true;
         $version = phpversion();
-        $wf = [];
+        $wf = array();
 
         // These needa be writable
         $wf[] = 'core/pages';
@@ -217,20 +217,20 @@ public static function SiteSetup()
         }
 
         // Add an initial airport/hub, because I love KJFK so much
-        $data = [
+        $data = array(
             'icao' => 'KJFK',
             'name' => 'Kennedy International',
             'country' => 'USA',
             'lat' => '40.6398',
             'lng' => '-73.7787',
             'hub' => false,
             'fuelprice' => 0,
-        ];
+        );
 
         $ret = OperationsData::AddAirport($data);
 
         // Add the user
-        $data = [
+        $data = array(
             'firstname' => $_POST['firstname'],
             'lastname' => $_POST['lastname'],
             'email' => $_POST['email'],
@@ -240,11 +240,10 @@ public static function SiteSetup()
             'location' => 'US',
             'hub' => 'KJFK',
             'confirm' => true,
-        ];
+        );
 
         if (!RegistrationData::AddUser($data)) {
             self::$error = DB::$error;
-
             return false;
         }