Fix deprecated v8 api calls

Author: pinepain

src/php_v8_date.cc

@@ -41,9 +41,11 @@ static PHP_METHOD(V8Date, __construct) {
 
     PHP_V8_OBJECT_CONSTRUCT(getThis(), php_v8_context_zv, php_v8_context, php_v8_value);
 
-    v8::Local<v8::Date> local_date = v8::Date::New(isolate, time).As<v8::Date>();
+    v8::MaybeLocal<v8::Value> maybe_local_date = v8::Date::New(context, time);
 
-    PHP_V8_THROW_VALUE_EXCEPTION_WHEN_EMPTY(local_date, "Failed to create Date value");
+    PHP_V8_THROW_VALUE_EXCEPTION_WHEN_EMPTY(maybe_local_date, "Failed to create Date value");
+
+    v8::Local<v8::Date> local_date = maybe_local_date.ToLocalChecked().As<v8::Date>();
 
     ZVAL_COPY_VALUE(&php_v8_value->this_ptr, getThis());
     php_v8_object_store_self_ptr(isolate, local_date, php_v8_value);

src/php_v8_function.cc

@@ -417,7 +417,7 @@ static PHP_METHOD(V8Function, GetScriptOrigin) {
 
     v8::ScriptOrigin script_origin = local_function->GetScriptOrigin();
 
-    php_v8_create_script_origin(return_value, script_origin);
+    php_v8_create_script_origin(return_value, context, script_origin);
 }
 
 

src/php_v8_message.cc

@@ -50,7 +50,7 @@ void php_v8_message_create_from_message(zval *return_value, php_v8_isolate_t *ph
 
     /* v8::Message::GetScriptOrigin */
     zval origin_zv;
-    php_v8_create_script_origin(&origin_zv, message->GetScriptOrigin());
+    php_v8_create_script_origin(&origin_zv, context, message->GetScriptOrigin());
     zend_update_property(this_ce, return_value, ZEND_STRL("script_origin"), &origin_zv);
     zval_ptr_dtor(&origin_zv);
 

src/php_v8_script.cc

@@ -103,7 +103,7 @@ static PHP_METHOD(V8Script, __construct)
         origin = new v8::ScriptOrigin(v8::Undefined(isolate));
 
         zval origin_zv;
-        php_v8_create_script_origin(&origin_zv, *origin);
+        php_v8_create_script_origin(&origin_zv, context, *origin);
         zend_update_property(this_ce, getThis(), ZEND_STRL("origin"), &origin_zv);
 
         zval_ptr_dtor(&origin_zv);

src/php_v8_script_origin.cc

@@ -25,7 +25,7 @@ zend_class_entry *php_v8_script_origin_class_entry;
 #define this_ce php_v8_script_origin_class_entry
 
 
-extern void php_v8_create_script_origin(zval *return_value, v8::ScriptOrigin origin) {
+extern void php_v8_create_script_origin(zval *return_value, v8::Local<v8::Context> context, v8::ScriptOrigin origin) {
     zval options_zv;
 
     object_init_ex(return_value, this_ce);
@@ -38,13 +38,13 @@ extern void php_v8_create_script_origin(zval *return_value, v8::ScriptOrigin ori
     }
 
     /* v8::SourceMapUrl::ResourceLineOffset */
-    if (!origin.ResourceLineOffset().IsEmpty()) {
-        zend_update_property_long(this_ce, return_value, ZEND_STRL("resource_line_offset"), static_cast<zend_long>(origin.ResourceLineOffset()->NumberValue()));
+    if (!origin.ResourceLineOffset().IsEmpty() && origin.ResourceLineOffset()->NumberValue(context).IsJust()) {
+        zend_update_property_long(this_ce, return_value, ZEND_STRL("resource_line_offset"), static_cast<zend_long>(origin.ResourceLineOffset()->NumberValue(context).FromJust()));
     }
 
     /* v8::SourceMapUrl::ResourceColumnOffset */
-    if (!origin.ResourceColumnOffset().IsEmpty()) {
-        zend_update_property_long(this_ce, return_value, ZEND_STRL("resource_column_offset"), static_cast<zend_long>(origin.ResourceColumnOffset()->NumberValue()));
+    if (!origin.ResourceColumnOffset().IsEmpty() && origin.ResourceColumnOffset()->NumberValue(context).IsJust()) {
+        zend_update_property_long(this_ce, return_value, ZEND_STRL("resource_column_offset"), static_cast<zend_long>(origin.ResourceColumnOffset()->NumberValue(context).FromJust()));
     }
 
     /* v8::SourceMapUrl::Options */
@@ -53,8 +53,8 @@ extern void php_v8_create_script_origin(zval *return_value, v8::ScriptOrigin ori
     zval_ptr_dtor(&options_zv);
 
     /* v8::SourceMapUrl::ScriptID */
-    if (!origin.ScriptID().IsEmpty()) {
-        zend_update_property_long(this_ce, return_value, ZEND_STRL("script_id"), static_cast<zend_long>(origin.ScriptID()->NumberValue()));
+    if (!origin.ScriptID().IsEmpty() && origin.ScriptID()->NumberValue(context).IsJust()) {
+        zend_update_property_long(this_ce, return_value, ZEND_STRL("script_id"), static_cast<zend_long>(origin.ScriptID()->NumberValue(context).FromJust()));
     }
 
     /* v8::SourceMapUrl::ResourceName */

src/php_v8_script_origin.h

@@ -27,7 +27,7 @@ extern "C" {
 
 extern zend_class_entry* php_v8_script_origin_class_entry;
 
-extern void php_v8_create_script_origin(zval * return_value, v8::ScriptOrigin origin);
+extern void php_v8_create_script_origin(zval * return_value, v8::Local<v8::Context> context, v8::ScriptOrigin origin);
 extern v8::ScriptOrigin *php_v8_create_script_origin_from_zval(zval *value, v8::Isolate *isolate);
 
 PHP_MINIT_FUNCTION (php_v8_script_origin);

src/php_v8_value.cc

@@ -678,7 +678,7 @@ static PHP_METHOD(V8Value, ToString) {
     PHP_V8_TRY_CATCH(isolate);
     PHP_V8_INIT_ISOLATE_LIMITS_ON_CONTEXT(php_v8_context);
 
-    v8::MaybeLocal<v8::String> maybe_local = php_v8_value_get_value_local(isolate, php_v8_value)->ToString(isolate);
+    v8::MaybeLocal<v8::String> maybe_local = php_v8_value_get_value_local(isolate, php_v8_value)->ToString(context);
 
     PHP_V8_MAYBE_CATCH(php_v8_context, try_catch);
     PHP_V8_THROW_EXCEPTION_WHEN_EMPTY(maybe_local, "Failed to convert");