Merge pull request #87 from pinepain/fix-upgrading

Land proper libv8 upgrading

Author: pinepain

.valgrind-docker.supp

@@ -117,7 +117,7 @@ if test "$PHP_V8" != "no"; then
   PHP_SUBST(V8_SHARED_LIBADD)
   PHP_REQUIRE_CXX()
 
-  CPPFLAGS="$CPPFLAGS -std=c++11"
+  CPPFLAGS="$CPPFLAGS -std=c++14"
 
   # On OS X clang reports warnings in zeng_strings.h, like
   #     php/Zend/zend_string.h:326:2: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register]

.valgrind-v8.supp

@@ -15,11 +15,9 @@ void weak_callback(const v8::WeakCallbackInfo<v8::Persistent<v8::String>>& data)
 int main(int argc, char* argv[]) {
   // Initialize V8.
   v8::V8::InitializeICU();
-  v8::Platform *platform = v8::platform::CreateDefaultPlatform();
-  v8::V8::InitializePlatform(platform);
 
-//  std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
-//  v8::V8::InitializePlatform(platform.get());
+  std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
+  v8::V8::InitializePlatform(platform.get());
 
   V8::Initialize();
 

.valgrindrc

@@ -8,10 +8,10 @@ INCLUDE_DIR=$ROOT/include
 
 set -x
 
-g++ -std=c++14 hello_world.cpp -o hello_world \
+g++ hello_world.cpp -o hello_world \
  -g \
  -O2 \
- -std=c++11 \
+ -std=c++14 \
  -I$INCLUDE_DIR \
  -L$LIB_DIR \
  -Wl,-rpath,$LIB_DIR \

config.m4

@@ -9,7 +9,7 @@ INCLUDE_DIR=$ROOT/include
 g++ hello_world.cpp -o hello_world \
  -g \
  -O2 \
- -std=c++11 \
+ -std=c++14 \
  -I$SRC_DIR \
  -I$INCLUDE_DIR \
  -L$LIB_DIR \

scripts/test_v8/hello_world.cpp

@@ -31,7 +31,9 @@ void php_v8_init()
 
     // If we use snapshot and extenal startup data then we have to initialize it (see https://codereview.chromium.org/315033002/)
     // v8::V8::InitializeExternalStartupData(NULL);
-    v8::Platform *platform = v8::platform::CreateDefaultPlatform();
+    std::unique_ptr<v8::Platform> platform_unique_ptr = v8::platform::NewDefaultPlatform();
+
+    v8::Platform *platform = platform_unique_ptr.release();
     v8::V8::InitializePlatform(platform);
 
 //    const char *flags = "--no-hard_abort";

scripts/test_v8/hello_world_build_deb.sh

@@ -53,7 +53,7 @@
  *    v8::Local<v8::ObjectTemplate> instance_t = t->InstanceTemplate();
  *    instance_t->SetAccessor(String::NewFromUtf8(isolate, "instance_accessor"),
  *                            InstanceAccessorCallback);
- *    instance_t->SetNamedPropertyHandler(PropertyHandlerCallback);
+ *    instance_t->SetHandler(NamedPropertyHandlerConfiguration(PropertyHandlerCallback));
  *    instance_t->Set(String::NewFromUtf8(isolate, "instance_property"),
  *                    Number::New(isolate, 3));
  *

scripts/test_v8/hello_world_build_osx.sh

@@ -2,8 +2,6 @@
 v8 extension info
 --SKIPIF--
 <?php if (!extension_loaded("v8")) print "skip"; ?>
---ENV--
-HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
 --FILE--
 <?php