Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit d18eedb

Browse files
authored
Merge pull request #11 from pinepain/stubss
Add stub files and cleanup config
2 parents aa9fb6e + cff2adb commit d18eedb

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

README.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,19 @@ $result = $script->Run($context);
5555
echo $result->ToString($context)->Value(), PHP_EOL;
5656
```
5757

58-
which will output `Hello, World!`. See how it's shorter and more readable than [that C++ version]([v8-hello-world])?
58+
which will output `Hello, World!`. See how it's shorter and more readable than [that C++ version][v8-hello-world]?
5959
And it also doesn't limit you from V8 API utilizing to implement more amazing stuff.
6060

61+
62+
## Stub files
63+
64+
If you are also using Composer, it is recommended to add the [php-v8-stub][php-v8-stubs]
65+
package as a dev-mode requirement. It provides skeleton definitions and annotations to enable support for auto-completion
66+
in your IDE and other code-analysis tools.
67+
68+
composer require --dev pinepain/php-v8-stubs
69+
70+
6171
## Installation
6272

6373
### Requirements
@@ -155,3 +165,4 @@ Copyright (c) 2015-2016 Bogdan Padalko <pinepain@gmail.com>
155165
[v8-intro]: https://developers.google.com/v8/intro
156166
[php70-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php70-v8.rb
157167
[php71-v8.rb]: https://github.com/pinepain/php-v8/blob/master/scripts/homebrew/php71-v8.rb
168+
[php-v8-stubs]: https://github.com/pinepain/php-v8-stubs

config.m4

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ if test "$PHP_V8" != "no"; then
7676

7777
for static_link_extra_file in $static_link_extra; do
7878
AC_MSG_CHECKING([for $static_link_extra_file])
79+
static_link_dir=""
7980

8081
for i in $PHP_V8 $SEARCH_PATH ; do
8182
if test -r $i/lib64/$static_link_extra_file; then
@@ -90,7 +91,7 @@ if test "$PHP_V8" != "no"; then
9091

9192
if test -z "$static_link_dir"; then
9293
AC_MSG_RESULT([not found])
93-
AC_MSG_ERROR([Please provide $static_link_extra_file next to the libv8.so, see README.md for details])
94+
AC_MSG_ERROR([Please provide $static_link_extra_file next to the libv8.so])
9495
fi
9596

9697
LDFLAGS="$LDFLAGS $static_link_dir/$static_link_extra_file"

0 commit comments

Comments
 (0)