[internals] Rename ScriptOrigin::{scriptID => scriptId}()

Author: pinepain

src/php_v8_script_origin.cc

@@ -224,7 +224,7 @@ static PHP_METHOD(ScriptOrigin, resourceColumnOffset) {
     RETVAL_ZVAL(zend_read_property(this_ce, getThis(), ZEND_STRL("resource_column_offset"), 0, &rv), 1, 0);
 }
 
-static PHP_METHOD(ScriptOrigin, scriptID) {
+static PHP_METHOD(ScriptOrigin, scriptId) {
     zval rv;
 
     if (zend_parse_parameters_none() == FAILURE) {
@@ -274,7 +274,7 @@ ZEND_END_ARG_INFO()
 PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_resourceColumnOffset, ZEND_RETURN_VALUE, 0, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
-PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_scriptID, ZEND_RETURN_VALUE, 0, IS_LONG, 0)
+PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_scriptId, ZEND_RETURN_VALUE, 0, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
 PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_sourceMapUrl, ZEND_RETURN_VALUE, 0, IS_STRING, 0)
@@ -289,7 +289,7 @@ static const zend_function_entry php_v8_script_origin_methods[] = {
         PHP_V8_ME(ScriptOrigin, resourceName,         ZEND_ACC_PUBLIC)
         PHP_V8_ME(ScriptOrigin, resourceLineOffset,   ZEND_ACC_PUBLIC)
         PHP_V8_ME(ScriptOrigin, resourceColumnOffset, ZEND_ACC_PUBLIC)
-        PHP_V8_ME(ScriptOrigin, scriptID,             ZEND_ACC_PUBLIC)
+        PHP_V8_ME(ScriptOrigin, scriptId,             ZEND_ACC_PUBLIC)
         PHP_V8_ME(ScriptOrigin, sourceMapUrl,         ZEND_ACC_PUBLIC)
         PHP_V8_ME(ScriptOrigin, options,              ZEND_ACC_PUBLIC)
 

tests/ScriptOrigin.phpt

@@ -19,7 +19,7 @@ $helper->header('Test getters (default)');
 $helper->method_matches_with_output($obj, 'resourceName', 'test');
 $helper->method_matches_with_output($obj, 'resourceLineOffset', 0);
 $helper->method_matches_with_output($obj, 'resourceColumnOffset', 0);
-$helper->method_matches_with_output($obj, 'scriptID', 0);
+$helper->method_matches_with_output($obj, 'scriptId', 0);
 $helper->method_matches_with_output($obj, 'sourceMapUrl', '');
 $helper->method_matches_instanceof($obj, 'options', V8\ScriptOriginOptions::class);
 $helper->space();
@@ -43,7 +43,7 @@ $helper->header('Test getters');
 $helper->method_matches_with_output($obj, 'resourceName', 'test');
 $helper->method_matches_with_output($obj, 'resourceLineOffset', 1);
 $helper->method_matches_with_output($obj, 'resourceColumnOffset', 2);
-$helper->method_matches_with_output($obj, 'scriptID', 3);
+$helper->method_matches_with_output($obj, 'scriptId', 3);
 $helper->method_matches_with_output($obj, 'sourceMapUrl', 'map');
 $helper->method_matches_instanceof($obj, 'options', V8\ScriptOriginOptions::class);
 $helper->space();
@@ -91,7 +91,7 @@ Test getters (default):
 V8\ScriptOrigin::resourceName() matches expected 'test'
 V8\ScriptOrigin::resourceLineOffset() matches expected 0
 V8\ScriptOrigin::resourceColumnOffset() matches expected 0
-V8\ScriptOrigin::scriptID() matches expected 0
+V8\ScriptOrigin::scriptId() matches expected 0
 V8\ScriptOrigin::sourceMapUrl() matches expected ''
 V8\ScriptOrigin::options() result is instance of V8\ScriptOriginOptions
 
@@ -134,7 +134,7 @@ Test getters:
 V8\ScriptOrigin::resourceName() matches expected 'test'
 V8\ScriptOrigin::resourceLineOffset() matches expected 1
 V8\ScriptOrigin::resourceColumnOffset() matches expected 2
-V8\ScriptOrigin::scriptID() matches expected 3
+V8\ScriptOrigin::scriptId() matches expected 3
 V8\ScriptOrigin::sourceMapUrl() matches expected 'map'
 V8\ScriptOrigin::options() result is instance of V8\ScriptOriginOptions