Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit afc95bf

Browse files
committed
Fix invalid params type hint, fixes #12
1 parent 9b060c4 commit afc95bf

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

src/php_v8_object.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1540,8 +1540,8 @@ ZEND_END_ARG_INFO()
15401540
//void method
15411541
ZEND_BEGIN_ARG_INFO_EX(arginfo_php_v8_object_SetAccessorProperty, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 2)
15421542
ZEND_ARG_OBJ_INFO(0, name, V8\\NameValue, 0)
1543-
ZEND_ARG_OBJ_INFO(0, getter, V8\\Function, 0)
1544-
ZEND_ARG_OBJ_INFO(0, setter, V8\\Function, 0)
1543+
ZEND_ARG_OBJ_INFO(0, getter, V8\\FunctionObject, 0)
1544+
ZEND_ARG_OBJ_INFO(0, setter, V8\\FunctionObject, 0)
15451545
ZEND_ARG_TYPE_INFO(0, attributes, IS_LONG, 0)
15461546
ZEND_ARG_TYPE_INFO(0, settings, IS_LONG, 0)
15471547
ZEND_END_ARG_INFO()

stubs/src/ObjectValue.php

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -221,19 +221,20 @@ public function SetAccessor(
221221
}
222222

223223
/**
224-
* @param NameValue $name
225-
* @param callable $getter
226-
* @param callable|null $setter
227-
* @param int $attributes
228-
* @param int $settings
224+
* @param NameValue $name
225+
* @param FunctionObject $getter
226+
* @param FunctionObject|null $setter
227+
* @param int $attributes
228+
* @param int $settings
229229
*/
230230
public function SetAccessorProperty(
231231
NameValue $name,
232-
callable $getter,
233-
callable $setter = null,
232+
FunctionObject $getter,
233+
FunctionObject $setter = null,
234234
int $attributes = PropertyAttribute::None,
235235
int $settings = AccessControl::DEFAULT_ACCESS
236-
) {
236+
)
237+
{
237238
}
238239

239240
/**

0 commit comments

Comments
 (0)