Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit ab24569

Browse files
committed
Cleanup V8\Script internals
1 parent 9bbe7f8 commit ab24569

File tree

2 files changed

+12
-25
lines changed

2 files changed

+12
-25
lines changed

src/php_v8_script.cc

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -215,37 +215,37 @@ static PHP_METHOD(V8Script, Run)
215215
}
216216

217217

218-
ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_source___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 2)
218+
ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_script___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 2)
219219
ZEND_ARG_OBJ_INFO(0, context, V8\\Context, 0)
220220
ZEND_ARG_OBJ_INFO(0, source, V8\\StringValue, 0)
221221
ZEND_ARG_OBJ_INFO(0, origin, V8\\ScriptOrigin, 0)
222222
ZEND_END_ARG_INFO()
223223

224-
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_source_GetIsolate, ZEND_RETURN_VALUE, 0, V8\\Isolate, 0)
224+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_script_GetIsolate, ZEND_RETURN_VALUE, 0, V8\\Isolate, 0)
225225
ZEND_END_ARG_INFO()
226226

227-
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_source_GetContext, ZEND_RETURN_VALUE, 0, V8\\Context, 0)
227+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_script_GetContext, ZEND_RETURN_VALUE, 0, V8\\Context, 0)
228228
ZEND_END_ARG_INFO()
229229

230-
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_source_getSource, ZEND_RETURN_VALUE, 0, V8\\StringValue, 0)
230+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_script_getSource, ZEND_RETURN_VALUE, 0, V8\\StringValue, 0)
231231
ZEND_END_ARG_INFO()
232232

233-
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_source_getOrigin, ZEND_RETURN_VALUE, 0, V8\\ScriptOrigin, 0)
233+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_script_getOrigin, ZEND_RETURN_VALUE, 0, V8\\ScriptOrigin, 0)
234234
ZEND_END_ARG_INFO()
235235

236-
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_source_Run, ZEND_RETURN_VALUE, 0, V8\\Value, 1)
236+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_v8_script_Run, ZEND_RETURN_VALUE, 0, V8\\Value, 1)
237237
ZEND_ARG_OBJ_INFO(0, context, V8\\Context, 0)
238238
ZEND_END_ARG_INFO()
239239

240240

241241
static const zend_function_entry php_v8_script_methods[] = {
242-
PHP_ME(V8Script, __construct, arginfo_v8_source___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
243-
PHP_ME(V8Script, GetIsolate, arginfo_v8_source_GetIsolate, ZEND_ACC_PUBLIC)
244-
PHP_ME(V8Script, GetContext, arginfo_v8_source_GetContext, ZEND_ACC_PUBLIC)
245-
PHP_ME(V8Script, getSource, arginfo_v8_source_getSource, ZEND_ACC_PUBLIC)
246-
PHP_ME(V8Script, getOrigin, arginfo_v8_source_getOrigin, ZEND_ACC_PUBLIC)
242+
PHP_ME(V8Script, __construct, arginfo_v8_script___construct, ZEND_ACC_PUBLIC | ZEND_ACC_CTOR)
243+
PHP_ME(V8Script, GetIsolate, arginfo_v8_script_GetIsolate, ZEND_ACC_PUBLIC)
244+
PHP_ME(V8Script, GetContext, arginfo_v8_script_GetContext, ZEND_ACC_PUBLIC)
245+
PHP_ME(V8Script, getSource, arginfo_v8_script_getSource, ZEND_ACC_PUBLIC)
246+
PHP_ME(V8Script, getOrigin, arginfo_v8_script_getOrigin, ZEND_ACC_PUBLIC)
247247

248-
PHP_ME(V8Script, Run, arginfo_v8_source_Run, ZEND_ACC_PUBLIC)
248+
PHP_ME(V8Script, Run, arginfo_v8_script_Run, ZEND_ACC_PUBLIC)
249249

250250
PHP_FE_END
251251
};

src/php_v8_script.h

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -64,19 +64,6 @@ struct _php_v8_script_t {
6464
};
6565

6666

67-
// Timer context
68-
//typedef struct _php_v8_limits_t
69-
//{
70-
// long time_limit;
71-
// long v8_memory_limit;
72-
// long zend_memory_limit;
73-
// std::chrono::time_point<std::chrono::high_resolution_clock> time_point;
74-
// v8js_ctx *ctx;
75-
// bool killed;
76-
//} php_v8_limits_t;
77-
78-
79-
8067
PHP_MINIT_FUNCTION(php_v8_script);
8168

8269
#endif //PHP_V8_SCRIPT_H

0 commit comments

Comments
 (0)