Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit a8404d6

Browse files
pinepainpinepain
committed
Add missed JSON class support, closes #56 
1 parent 5341a5d commit a8404d6

File tree

7 files changed

+320
-0
lines changed

7 files changed

+320
-0
lines changed

‎config.m4‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ if test "$PHP_V8" != "no"; then
215215
src/php_v8_property_callback_info.cc \
216216
src/php_v8_named_property_handler_configuration.cc \
217217
src/php_v8_indexed_property_handler_configuration.cc \
218+
src/php_v8_json.cc \
218219
], $ext_shared, , -DZEND_ENABLE_STATIC_TSRMLS_CACHE=1)
219220

220221
PHP_ADD_BUILD_DIR($ext_builddir/src)

‎src/php_v8_json.cc‎

Lines changed: 124 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,124 @@
1+
/*
2+
* This file is part of the pinepain/php-v8 PHP extension.
3+
*
4+
* Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
5+
*
6+
* Licensed under the MIT license: http://opensource.org/licenses/MIT
7+
*
8+
* For the full copyright and license information, please view the
9+
* LICENSE file that was distributed with this source or visit
10+
* http://opensource.org/licenses/MIT
11+
*/
12+
13+
#ifdef HAVE_CONFIG_H
14+
#include "config.h"
15+
#endif
16+
17+
#include "php_v8_json.h"
18+
#include "php_v8_value.h"
19+
#include "php_v8_context.h"
20+
#include "php_v8.h"
21+
22+
zend_class_entry *php_v8_json_class_entry;
23+
#define this_ce php_v8_json_class_entry
24+
25+
26+
static PHP_METHOD(JSON, parse) {
27+
zval *php_v8_context_zv;
28+
zval *php_v8_string_zv;
29+
30+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "oo", &php_v8_context_zv, &php_v8_string_zv) == FAILURE) {
31+
return;
32+
}
33+
34+
PHP_V8_VALUE_FETCH_WITH_CHECK(php_v8_string_zv, php_v8_string);
35+
PHP_V8_CONTEXT_FETCH_WITH_CHECK(php_v8_context_zv, php_v8_context);
36+
37+
PHP_V8_DATA_ISOLATES_CHECK(php_v8_context, php_v8_string);
38+
39+
PHP_V8_ENTER_STORED_ISOLATE(php_v8_context);
40+
PHP_V8_ENTER_CONTEXT(php_v8_context);
41+
42+
v8::Local<v8::String> local_string = php_v8_value_get_local_as<v8::String>(php_v8_string);
43+
44+
PHP_V8_TRY_CATCH(isolate);
45+
PHP_V8_INIT_ISOLATE_LIMITS_ON_CONTEXT(php_v8_context);
46+
47+
v8::MaybeLocal<v8::Value> maybe_local_value = v8::JSON::Parse(context, local_string);
48+
49+
PHP_V8_MAYBE_CATCH(php_v8_context, try_catch);
50+
PHP_V8_THROW_EXCEPTION_WHEN_EMPTY(maybe_local_value, "Failed to parse");
51+
52+
php_v8_get_or_create_value(return_value, maybe_local_value.ToLocalChecked(), php_v8_context->php_v8_isolate);
53+
}
54+
55+
static PHP_METHOD(JSON, stringify) {
56+
zval *php_v8_context_zv;
57+
zval *php_v8_value_zv = NULL;
58+
zval *php_v8_gap_zv = NULL;
59+
60+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "oo|o", &php_v8_context_zv, &php_v8_value_zv, &php_v8_gap_zv) == FAILURE) {
61+
return;
62+
}
63+
64+
PHP_V8_CONTEXT_FETCH_WITH_CHECK(php_v8_context_zv, php_v8_context);
65+
PHP_V8_VALUE_FETCH_WITH_CHECK(php_v8_value_zv, php_v8_value);
66+
67+
PHP_V8_DATA_ISOLATES_CHECK(php_v8_context, php_v8_value);
68+
69+
PHP_V8_ENTER_STORED_ISOLATE(php_v8_context);
70+
PHP_V8_ENTER_CONTEXT(php_v8_context);
71+
72+
v8::Local<v8::String> local_gap;
73+
74+
if (NULL != php_v8_gap_zv) {
75+
PHP_V8_VALUE_FETCH_WITH_CHECK(php_v8_gap_zv, php_v8_gap);
76+
PHP_V8_DATA_ISOLATES_CHECK(php_v8_context, php_v8_gap);
77+
local_gap = php_v8_value_get_local_as<v8::String>(php_v8_gap);
78+
}
79+
80+
v8::Local<v8::Value> local_value = php_v8_value_get_local_as<v8::Value>(php_v8_value);
81+
82+
PHP_V8_TRY_CATCH(isolate);
83+
PHP_V8_INIT_ISOLATE_LIMITS_ON_CONTEXT(php_v8_context);
84+
85+
v8::MaybeLocal<v8::String> maybe_local_string = v8::JSON::Stringify(context, local_value, local_gap);
86+
87+
PHP_V8_MAYBE_CATCH(php_v8_context, try_catch);
88+
PHP_V8_THROW_EXCEPTION_WHEN_EMPTY(maybe_local_string, "Failed to stringify");
89+
90+
v8::String::Utf8Value str(isolate, maybe_local_string.ToLocalChecked());
91+
92+
PHP_V8_CONVERT_UTF8VALUE_TO_STRING_WITH_CHECK(str, cstr);
93+
94+
RETVAL_STRINGL(cstr, str.length());
95+
}
96+
97+
98+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_parse, ZEND_RETURN_VALUE, 2, V8\\Value, 0)
99+
ZEND_ARG_OBJ_INFO(0, context, V8\\Context, 0)
100+
ZEND_ARG_OBJ_INFO(0, json_string, V8\\StringValue, 0)
101+
ZEND_END_ARG_INFO()
102+
103+
PHP_V8_ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_stringify, ZEND_RETURN_VALUE, 2, IS_STRING, 0)
104+
ZEND_ARG_OBJ_INFO(0, context, V8\\Context, 0)
105+
ZEND_ARG_OBJ_INFO(0, json_value, V8\\Value, 0)
106+
ZEND_ARG_OBJ_INFO(0, gap, V8\\StringValue, 1)
107+
ZEND_END_ARG_INFO()
108+
109+
110+
static const zend_function_entry php_v8_json_methods[] = {
111+
PHP_V8_ME(JSON, parse, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
112+
PHP_V8_ME(JSON, stringify, ZEND_ACC_PUBLIC | ZEND_ACC_STATIC)
113+
114+
PHP_FE_END
115+
};
116+
117+
118+
PHP_MINIT_FUNCTION(php_v8_json) {
119+
zend_class_entry ce;
120+
INIT_NS_CLASS_ENTRY(ce, PHP_V8_NS, "JSON", php_v8_json_methods);
121+
this_ce = zend_register_internal_class(&ce);
122+
123+
return SUCCESS;
124+
}

‎src/php_v8_json.h‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
/*
2+
* This file is part of the pinepain/php-v8 PHP extension.
3+
*
4+
* Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
5+
*
6+
* Licensed under the MIT license: http://opensource.org/licenses/MIT
7+
*
8+
* For the full copyright and license information, please view the
9+
* LICENSE file that was distributed with this source or visit
10+
* http://opensource.org/licenses/MIT
11+
*/
12+
13+
#ifndef PHP_V8_JSON_H
14+
#define PHP_V8_JSON_H
15+
16+
extern "C" {
17+
#include "php.h"
18+
19+
#ifdef ZTS
20+
#include "TSRM.h"
21+
#endif
22+
}
23+
24+
extern zend_class_entry* php_v8_json_class_entry;
25+
26+
27+
PHP_MINIT_FUNCTION(php_v8_json);
28+
29+
#endif //PHP_V8_JSON_H

‎stubs/src/JSON.php‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
<?php declare(strict_types=1);
2+
3+
/**
4+
* This file is part of the pinepain/php-v8 PHP extension.
5+
*
6+
* Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
7+
*
8+
* Licensed under the MIT license: http://opensource.org/licenses/MIT
9+
*
10+
* For the full copyright and license information, please view the
11+
* LICENSE file that was distributed with this source or visit
12+
* http://opensource.org/licenses/MIT
13+
*/
14+
15+
16+
namespace V8;
17+
18+
/**
19+
* A JSON Parser and Stringifier.
20+
*/
21+
class JSON extends IntegerValue
22+
{
23+
/**
24+
* Tries to parse the string |json_string| and returns it as value if
25+
* successful.
26+
*
27+
* @param Context $context
28+
* @param String $json_string The string to parse.
29+
*
30+
* @return Value|PrimitiveValue|ObjectValue
31+
*/
32+
public static function parse(Context $context, String $json_string): Value
33+
{
34+
}
35+
36+
/**
37+
* Tries to stringify the JSON-serializable object |json_object| and returns
38+
* it as string if successful.
39+
*
40+
* @param Context $context
41+
* @param Value $json_value The JSON-serializable value to stringify.
42+
* @param String|null $gap
43+
*
44+
* @return string
45+
*/
46+
public static function stringify(Context $context, Value $json_value, String $gap = null): string
47+
{
48+
}
49+
}

‎tests/001-verify_extension_entities.phpt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -925,3 +925,7 @@ class V8\NamedPropertyHandlerConfiguration
925925

926926
class V8\IndexedPropertyHandlerConfiguration
927927
public function __construct(callable $getter, ?callable $setter, ?callable $query, ?callable $deleter, ?callable $enumerator, int $flags)
928+
929+
class V8\JSON
930+
public static function parse(V8\Context $context, V8\StringValue $json_string): V8\Value
931+
public static function stringify(V8\Context $context, V8\Value $json_value, ?V8\StringValue $gap): string

‎tests/JSON.phpt‎

Lines changed: 110 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,110 @@
1+
--TEST--
2+
JSON
3+
--SKIPIF--
4+
<?php if (!extension_loaded("v8")) print "skip"; ?>
5+
--ENV--
6+
HOME=/tmp/we-need-home-env-var-set-to-load-valgrindrc
7+
--FILE--
8+
<?php
9+
require '.tracking_dtors.php';
10+
11+
/** @var \Phpv8Testsuite $helper */
12+
$helper = require '.testsuite.php';
13+
14+
require '.v8-helpers.php';
15+
$v8_helper = new PhpV8Helpers($helper);
16+
17+
18+
$isolate = new V8\Isolate();
19+
$context = new V8\Context($isolate);
20+
21+
$helper->header('Parse');
22+
23+
$res = V8\JSON::parse($context, new V8\StringValue($isolate, '"test"'));
24+
$helper->dump($res);
25+
$helper->line();
26+
27+
$res = V8\JSON::parse($context, new V8\StringValue($isolate, '[]'));
28+
$helper->dump($res);
29+
$helper->line();
30+
31+
$res = V8\JSON::parse($context, new V8\StringValue($isolate, '{}'));
32+
$helper->dump($res);
33+
$helper->line();
34+
35+
try {
36+
V8\JSON::parse($context, new V8\StringValue($isolate, '[123}'));
37+
} catch (\V8\Exceptions\TryCatchException $e) {
38+
$helper->exception_export($e);
39+
$helper->line();
40+
}
41+
42+
$helper->header('Stringify');
43+
44+
$res = V8\JSON::stringify($context, new V8\StringValue($isolate, 'test'));
45+
$helper->dump($res);
46+
$helper->line();
47+
48+
$obj_inner = new \V8\ObjectValue($context);
49+
$obj_inner->set($context, new \V8\StringValue($isolate, 'bar'), new \V8\StringValue($isolate, 'baz'));
50+
$obj = new \V8\ObjectValue($context);
51+
$obj->set($context, new \V8\StringValue($isolate, 'foo'), $obj_inner);
52+
53+
54+
$res = V8\JSON::stringify($context, $obj);
55+
$helper->dump($res);
56+
$helper->line();
57+
58+
$res = V8\JSON::stringify($context, $obj, new \V8\StringValue($isolate, ' '));
59+
$helper->dump($res);
60+
$helper->line();
61+
62+
63+
64+
?>
65+
--EXPECT--
66+
Parse:
67+
------
68+
object(V8\StringValue)#6 (1) {
69+
["isolate":"V8\Value":private]=>
70+
object(V8\Isolate)#3 (0) {
71+
}
72+
}
73+
74+
object(V8\ArrayObject)#7 (2) {
75+
["isolate":"V8\Value":private]=>
76+
object(V8\Isolate)#3 (0) {
77+
}
78+
["context":"V8\ObjectValue":private]=>
79+
object(V8\Context)#4 (1) {
80+
["isolate":"V8\Context":private]=>
81+
object(V8\Isolate)#3 (0) {
82+
}
83+
}
84+
}
85+
86+
object(V8\ObjectValue)#5 (2) {
87+
["isolate":"V8\Value":private]=>
88+
object(V8\Isolate)#3 (0) {
89+
}
90+
["context":"V8\ObjectValue":private]=>
91+
object(V8\Context)#4 (1) {
92+
["isolate":"V8\Context":private]=>
93+
object(V8\Isolate)#3 (0) {
94+
}
95+
}
96+
}
97+
98+
V8\Exceptions\TryCatchException: SyntaxError: Unexpected token } in JSON at position 4
99+
100+
Stringify:
101+
----------
102+
string(6) ""test""
103+
104+
string(21) "{"foo":{"bar":"baz"}}"
105+
106+
string(43) "{
107+
"foo": {
108+
"bar": "baz"
109+
}
110+
}"

‎v8.cc‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@
6666
#include "php_v8_function_callback_info.h"
6767
#include "php_v8_named_property_handler_configuration.h"
6868
#include "php_v8_indexed_property_handler_configuration.h"
69+
#include "php_v8_json.h"
6970

7071
#include "php_v8_value.h"
7172
#include "php_v8_data.h"
@@ -167,6 +168,8 @@ PHP_MINIT_FUNCTION(v8)
167168
PHP_MINIT(php_v8_named_property_handler_configuration)(INIT_FUNC_ARGS_PASSTHRU);
168169
PHP_MINIT(php_v8_indexed_property_handler_configuration)(INIT_FUNC_ARGS_PASSTHRU);
169170

171+
PHP_MINIT(php_v8_json)(INIT_FUNC_ARGS_PASSTHRU);
172+
170173
/* If you have INI entries, uncomment these lines
171174
REGISTER_INI_ENTRIES();
172175
*/

0 commit comments

Comments
 (0)