Reland proper libv8 upgrading

Author: pinepain

.valgrindrc

@@ -1,3 +0,0 @@
---gen-suppressions=all
---suppressions=./.valgrind-v8.supp
---suppressions=./.valgrind-docker.supp

config.m4

@@ -117,7 +117,7 @@ if test "$PHP_V8" != "no"; then
   PHP_SUBST(V8_SHARED_LIBADD)
   PHP_REQUIRE_CXX()
 
-  CPPFLAGS="$CPPFLAGS -std=c++11"
+  CPPFLAGS="$CPPFLAGS -std=c++14"
 
   # On OS X clang reports warnings in zeng_strings.h, like
   #     php/Zend/zend_string.h:326:2: warning: 'register' storage class specifier is deprecated [-Wdeprecated-register]

scripts/test_v8/hello_world.cpp

@@ -15,11 +15,9 @@ void weak_callback(const v8::WeakCallbackInfo<v8::Persistent<v8::String>>& data)
 int main(int argc, char* argv[]) {
   // Initialize V8.
   v8::V8::InitializeICU();
-  v8::Platform *platform = v8::platform::CreateDefaultPlatform();
-  v8::V8::InitializePlatform(platform);
 
-//  std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
-//  v8::V8::InitializePlatform(platform.get());
+  std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
+  v8::V8::InitializePlatform(platform.get());
 
   V8::Initialize();
 

scripts/test_v8/hello_world_build_deb.sh

@@ -8,10 +8,10 @@ INCLUDE_DIR=$ROOT/include
 
 set -x
 
-g++ -std=c++14 hello_world.cpp -o hello_world \
+g++ hello_world.cpp -o hello_world \
  -g \
  -O2 \
- -std=c++11 \
+ -std=c++14 \
  -I$INCLUDE_DIR \
  -L$LIB_DIR \
  -Wl,-rpath,$LIB_DIR \

scripts/test_v8/hello_world_build_osx.sh

@@ -9,7 +9,7 @@ INCLUDE_DIR=$ROOT/include
 g++ hello_world.cpp -o hello_world \
  -g \
  -O2 \
- -std=c++11 \
+ -std=c++14 \
  -I$SRC_DIR \
  -I$INCLUDE_DIR \
  -L$LIB_DIR \

src/php_v8_a.cc

@@ -31,7 +31,9 @@ void php_v8_init()
 
     // If we use snapshot and extenal startup data then we have to initialize it (see https://codereview.chromium.org/315033002/)
     // v8::V8::InitializeExternalStartupData(NULL);
-    v8::Platform *platform = v8::platform::CreateDefaultPlatform();
+    std::unique_ptr<v8::Platform> platform_unique_ptr = v8::platform::NewDefaultPlatform();
+
+    v8::Platform *platform = platform_unique_ptr.release();
     v8::V8::InitializePlatform(platform);
 
 //    const char *flags = "--no-hard_abort";