Require v8 >= 6.1.170

Author: pinepain

.travis.yml

@@ -17,8 +17,8 @@ env:
     - NO_INTERACTION=1
     - TEST_TIMEOUT=120
   matrix:
-    - V8=6.0
-    - V8=6.0 TEST_PHP_ARGS=-m
+    - V8=6.1
+    - V8=6.1 TEST_PHP_ARGS=-m
 
 before_install:
   - sudo add-apt-repository ppa:pinepain/libv8-${V8} -y

CMakeLists.txt

@@ -3,8 +3,8 @@ project(php_v8)
 
 # NOTE: This CMake file is just for syntax highlighting in CLion
 
-include_directories(/usr/local/opt/v8@6.0/include)
-include_directories(/usr/local/opt/v8@6.0/include/libplatform)
+include_directories(/usr/local/opt/v8@6.1/include)
+include_directories(/usr/local/opt/v8@6.1/include/libplatform)
 
 include_directories(/usr/local/include/php)
 include_directories(/usr/local/include/php/TSRM)

README.md

@@ -73,14 +73,14 @@ in your IDE and other code-analysis tools.
 ### Requirements
 
 #### V8
-You will need a recent v8 Google JavaScript engine version installed. At this time the extension is tested on 6.0.45.
+You will need a recent v8 Google JavaScript engine version installed. At this time the extension is tested on 6.1.170.
 
 #### PHP
 This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
 
 #### OS
 This extension works and tested on x64 Linux and macOS. As of written it is Ubuntu 16.04 LTS Xenial Xerus, amd64
-and macOS 10.12.1. Windows is not supported at this time.
+and macOS 10.12.5. Windows is not supported at this time.
 
 ### Quick guide
 
@@ -96,7 +96,7 @@ $ php --ri v8
 
 While [pinepain/php](https://launchpad.net/~pinepain/+archive/ubuntu/php) PPA targets to contain all necessary
 extensions with dependencies, you may find
-[pinepain/libv8-6.0](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.0),
+[pinepain/libv8-6.1](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.1),
 [pinepain/libv8-experimental](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-experimental) and
 [pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) standalone PPAs useful.
 

config.m4

@@ -8,7 +8,7 @@ if test "$PHP_V8" != "no"; then
   SEARCH_PATH="/usr/local /usr"
   SEARCH_FOR="include/v8.h"
 
-  V8_MIN_API_VERSION_STR=6.0.45
+  V8_MIN_API_VERSION_STR=6.1.170
 
   DESIRED_V8_VERSION=`echo "${V8_MIN_API_VERSION_STR}" | $AWK 'BEGIN { FS = "."; } { printf "%s.%s", [$]1, [$]2;}'`
 

scripts/provision/provision.sh

@@ -5,7 +5,7 @@ echo Provisioning...
 # Add Ondřej Surý's PPA with co-installable PHP versions:
 sudo add-apt-repository -y ppa:ondrej/php
 # Add libv8 PPA:
-sudo add-apt-repository ppa:pinepain/libv8-6.0
+sudo add-apt-repository ppa:pinepain/libv8-6.1
 
 # Let's update packages list:
 sudo apt-get update
@@ -19,7 +19,7 @@ sudo apt-get install -y git htop curl pkgconf
 
 
 # Build and development requirements
-sudo apt-get install -y libv8-6.0 libv8-6.0-dev libv8-6.0-dbg
+sudo apt-get install -y libv8-6.1 libv8-6.1-dev libv8-6.1-dbg
 sudo apt-get install -y dh-make valgrind
 sudo apt-get install -y libssl-dev openssl
 sudo apt-get install -y php7.0 php7.0-cli php7.0-dev php7.0-fpm

src/php_v8_value.cc

@@ -314,16 +314,6 @@ php_v8_value_t *php_v8_get_or_create_value(zval *return_value, v8::Local<v8::Val
 }
 
 
-//static PHP_METHOD (V8Value, __construct) {
-//    zval *php_v8_isolate_zv;
-//
-//    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o", &php_v8_isolate_zv) == FAILURE) {
-//        return;
-//    }
-//
-//    PHP_V8_THROW_EXCEPTION("V8\\Value::__construct() should not be called. Use specific values instead.")
-//}
-
 static PHP_METHOD(V8Value, GetIsolate) {
     zval rv;
 

tests/004-ICU-Intl_DateTimeFormat.phpt

@@ -75,7 +75,7 @@ console.log(new Intl.DateTimeFormat('de-DE', options).format(date));
 options.timeZone = 'UTC';
 options.timeZoneName = 'short';
 console.log(new Intl.DateTimeFormat('en-US', options).format(date));
-// → "Thursday, December 20, 2012, GMT"
+// → "Thursday, December 20, 2012, UTC"
 
 // sometimes you want to be more precise
 var options = {
@@ -129,8 +129,8 @@ HEREDOC;
 20/12/2012
 
 Donnerstag, 20. Dezember 2012
-Thursday, December 20, 2012, GMT
-3:00:00 am GMT
+Thursday, December 20, 2012, UTC
+3:00:00 am UTC
 12/20/2012, 03:00:00
 
 Wednesday, December 19, 2012

tests/V8DateObject.phpt

@@ -96,7 +96,9 @@ val
 $file_name = 'test.js';
 
 // TODO: for some reason v8 still be notified about TZ changes, see https://groups.google.com/forum/?fromgroups#!topic/v8-users/f249jR67ANk
-// TODO: we temporary set EDT instead of PDT which was before
+// We temporary set EDT instead of PDT which was before, this should lead to no error, but the output date value is
+// undefined, it's a must to invoke \V8\DateObject::DateTimeConfigurationChangeNotification($isolate); as we did before.
+// This case is verify that no segfault or exception thrown and to demonstrate that result is not what you expect to get.
 $script = new V8\Script($context, new \V8\StringValue($isolate, $source), new \V8\ScriptOrigin($file_name));
 $res = $script->Run($context);
 $helper->value_matches($test_time, $value->ValueOf());
@@ -106,7 +108,7 @@ putenv("TZ={$old_tz}"); // Go back
 
 
 ?>
---EXPECT--
+--EXPECTF--
 Object representation:
 ----------------------
 object(V8\DateObject)#6 (2) {
@@ -204,6 +206,6 @@ Expected 1445444940000.0 value is identical to actual value 1445444940000.0
 
 Timezone change (without notification to v8):
 ---------------------------------------------
-val: Wed Oct 21 2015 09:29:00 GMT-0700 (PDT)
+val: Wed Oct 21 2015 09:29:00 GMT-0700 (%sDT)
 typeof val: object
 Expected 1445444940000.0 value is identical to actual value 1445444940000.0