Disable ObjectTemplate::MarkAsUndetectable() method

Author: pinepain

src/php_v8_object_template.cc

@@ -371,7 +371,8 @@ static PHP_METHOD(V8ObjectTemplate, SetCallAsFunctionHandler) {
 
     local_template->SetCallAsFunctionHandler(callback, data);
 }
-
+// NOTE: Method is not supported anymore due to a limited use and a way it implemented (causes segfault under certain conditions)
+/*
 static PHP_METHOD(V8ObjectTemplate, MarkAsUndetectable) {
     if (zend_parse_parameters_none() == FAILURE) {
         return;
@@ -384,6 +385,7 @@ static PHP_METHOD(V8ObjectTemplate, MarkAsUndetectable) {
 
     local_template->MarkAsUndetectable();
 }
+*/
 
 // not used currently
 static PHP_METHOD(V8ObjectTemplate, SetAccessCheckCallback) {
@@ -479,15 +481,20 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_php_v8_object_template_SetCallAsFunctionHandler,
                 ZEND_ARG_INFO(0, callback)
 ZEND_END_ARG_INFO()
 
+// not used
 // void method
+/*
 ZEND_BEGIN_ARG_INFO_EX(arginfo_php_v8_object_template_MarkAsUndetectable, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 0)
 ZEND_END_ARG_INFO()
+*/
 
 // not used
 // void method
+/*
 ZEND_BEGIN_ARG_INFO_EX(arginfo_php_v8_object_template_SetAccessCheckCallback, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 1)
                 ZEND_ARG_CALLABLE_INFO(0, callback, 1)
 ZEND_END_ARG_INFO()
+*/
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_v8_object_template_AdjustExternalAllocatedMemory, ZEND_RETURN_VALUE, 1, IS_LONG, NULL, 0)
                 ZEND_ARG_TYPE_INFO(0, change_in_bytes, IS_LONG, 0)
@@ -513,7 +520,7 @@ static const zend_function_entry php_v8_object_template_methods[] = {
         PHP_ME(V8ObjectTemplate, SetHandlerForNamedProperty, arginfo_php_v8_object_template_SetHandlerForNamedProperty, ZEND_ACC_PUBLIC)
         PHP_ME(V8ObjectTemplate, SetHandlerForIndexedProperty, arginfo_php_v8_object_template_SetHandlerForIndexedProperty, ZEND_ACC_PUBLIC)
         PHP_ME(V8ObjectTemplate, SetCallAsFunctionHandler, arginfo_php_v8_object_template_SetCallAsFunctionHandler, ZEND_ACC_PUBLIC)
-        PHP_ME(V8ObjectTemplate, MarkAsUndetectable, arginfo_php_v8_object_template_MarkAsUndetectable, ZEND_ACC_PUBLIC)
+//        PHP_ME(V8ObjectTemplate, MarkAsUndetectable, arginfo_php_v8_object_template_MarkAsUndetectable, ZEND_ACC_PUBLIC)
 //        PHP_ME(V8ObjectTemplate, SetAccessCheckCallback, arginfo_php_v8_object_template_SetAccessCheckCallback, ZEND_ACC_PUBLIC)
 
         PHP_ME(V8ObjectTemplate, AdjustExternalAllocatedMemory, arginfo_v8_object_template_AdjustExternalAllocatedMemory, ZEND_ACC_PUBLIC)

stubs/src/ObjectTemplate.php

@@ -142,17 +142,31 @@ public function SetCallAsFunctionHandler(callable $callback)
     {
     }
 
-    /**
-     * Mark object instances of the template as undetectable.
-     *
-     * In many ways, undetectable objects behave as though they are not
-     * there.  They behave like 'undefined' in conditionals and when
-     * printed.  However, properties can be accessed and called as on
-     * normal objects.
-     */
-    public function MarkAsUndetectable()
-    {
-    }
+    // Method is not supported anymore due to a limited use and a way it implemented (causes segfault under certain conditions)
+    // see v8/src/api-natives.cc:677
+    //  // Mark as undetectable if needed.
+    //  if (obj->undetectable()) {
+    //    // We only allow callable undetectable receivers here, since this whole
+    //    // undetectable business is only to support document.all, which is both
+    //    // undetectable and callable. If we ever see the need to have an object
+    //    // that is undetectable but not callable, we need to update the types.h
+    //    // to allow encoding this.
+    //    CHECK(!obj->instance_call_handler()->IsUndefined(isolate));
+    //    map->set_is_undetectable();
+    //  }
+
+
+    ///**
+    // * Mark object instances of the template as undetectable.
+    // *
+    // * In many ways, undetectable objects behave as though they are not
+    // * there.  They behave like 'undefined' in conditionals and when
+    // * printed.  However, properties can be accessed and called as on
+    // * normal objects.
+    // */
+    //public function MarkAsUndetectable()
+    //{
+    //}
 
     // Disabled due to https://groups.google.com/forum/#!topic/v8-dev/c7LhW2bNabY and it should be not necessary to use
     // it in other then browser setup in most cases, though It would be nice to have it for API consistency reason.

tests/V8ObjectTemplate_MarkAsUndetectable.phpt

@@ -1,6 +1,7 @@
 --TEST--
 V8\ObjectTemplate::MarkAsUndetectable
 --SKIPIF--
+<?php print "skip Method is not supported anymore due to a limited use and a way it implemented (causes segfault under certain conditions)"; ?>
 <?php if (!extension_loaded("v8")) { print "skip"; } ?>
 --FILE--
 <?php