Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 6803719

Browse files
committed
Raise required v8 version to 5.8.168
1 parent 78cd420 commit 6803719

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ env:
1717
- NO_INTERACTION=1
1818
- TEST_TIMEOUT=120
1919
matrix:
20-
- V8=5.7
21-
- V8=5.7 TEST_PHP_ARGS=-m
20+
- V8=5.8
21+
- V8=5.8 TEST_PHP_ARGS=-m
2222

2323
before_install:
2424
- sudo add-apt-repository ppa:pinepain/libv8-${V8} -y

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ project(php_v8)
33

44
# NOTE: This CMake file is just for syntax highlighting in CLion
55

6-
include_directories(/usr/local/opt/v8@5.7/include)
7-
include_directories(/usr/local/opt/v8@5.7/include/libplatform)
6+
include_directories(/usr/local/opt/v8@5.8/include)
7+
include_directories(/usr/local/opt/v8@5.8/include/libplatform)
88

99
include_directories(/usr/local/include/php)
1010
include_directories(/usr/local/include/php/TSRM)

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ in your IDE and other code-analysis tools.
7373
### Requirements
7474

7575
#### V8
76-
You will need a recent v8 Google JavaScript engine version installed. At this time the extension is tested on 5.7.514.
76+
You will need a recent v8 Google JavaScript engine version installed. At this time the extension is tested on 5.8.168.
7777

7878
#### PHP
7979
This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
@@ -96,7 +96,7 @@ $ php --ri v8
9696

9797
While [pinepain/php](https://launchpad.net/~pinepain/+archive/ubuntu/php) PPA targets to contain all necessary
9898
extensions with dependencies, you may find
99-
[pinepain/libv8-5.7](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-5.7),
99+
[pinepain/libv8-5.8](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-5.8),
100100
[pinepain/libv8-experimental](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-experimental) and
101101
[pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) standalone PPAs useful.
102102

@@ -108,7 +108,7 @@ $ brew tap homebrew/dupes
108108
$ brew tap homebrew/php
109109
$ brew tap pinepain/devtools
110110
$ brew install php70
111-
$ brew install v8@5.7
111+
$ brew install v8@5.8
112112
$ brew install php70-v8
113113
$ php --ri v8
114114
```

config.m4

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ if test "$PHP_V8" != "no"; then
88
SEARCH_PATH="/usr/local /usr"
99
SEARCH_FOR="include/v8.h"
1010

11-
V8_MIN_API_VERSION_STR=5.7.514
11+
V8_MIN_API_VERSION_STR=5.8.168
1212

1313
DESIRED_V8_VERSION=`echo "${V8_MIN_API_VERSION_STR}" | $AWK 'BEGIN { FS = "."; } { printf "%s.%s", [$]1, [$]2;}'`
1414

@@ -127,7 +127,7 @@ if test "$PHP_V8" != "no"; then
127127
# php/Zend/zend_operators.h:128:18: warning: 'finite' is deprecated: first deprecated in macOS 10.9 [-Wdeprecated-declarations]
128128
# but as we want to track also deprecated methods from v8 we won't ignore -Wdeprecated-declarations warnings
129129
# We want to make building log cleaner, so let's suppress only -Wdeprecated-register warning
130-
PHP_V8_COMPILER_OPTIONS="-Wno-deprecated-register"
130+
PHP_V8_COMPILER_OPTIONS="-Wno-deprecated-register -Wno-unicode"
131131
#PHP_V8_COMPILER_OPTIONS="-Wno-deprecated-register -Wno-deprecated-declarations"
132132

133133
AC_DEFINE([V8_DEPRECATION_WARNINGS], [1], [Enable compiler warnings when using V8_DEPRECATED apis.])

0 commit comments

Comments
 (0)