Merge pull request #81 from pinepain/upgrade-v8-version

Upgrade to libv8 6.5.116

Author: pinepain

.travis.yml

@@ -6,12 +6,12 @@ services:
 
 env:
   global:
-    - V8=6.4
+    - V8=6.5
   matrix:
-    - TAG=xenial-v8-64-php-71
-    - TAG=xenial-v8-64-php-71 TEST_PHP_ARGS=-m
-    - TAG=xenial-v8-64-php-72
-    - TAG=xenial-v8-64-php-72 TEST_PHP_ARGS=-m
+    - TAG=xenial-v8-65-php-71
+    - TAG=xenial-v8-65-php-71 TEST_PHP_ARGS=-m
+    - TAG=xenial-v8-65-php-72
+    - TAG=xenial-v8-65-php-72 TEST_PHP_ARGS=-m
 
 before_install:
   # docker on travis doesn't allow anything before FROM, let's fix that

.valgrind-v8.supp

@@ -4,3 +4,33 @@
    fun:_ZN2v88internal20MarkCompactCollector20EmptyMarkingWorklistEv
    ...
 }
+{
+   <suppress_false_positive_warning_see_v8_issue_6566_workarond_for_603286>
+   Memcheck:Cond
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   fun:_ZL33zim_Isolate_lowMemoryNotificationP18_zend_execute_dataP12_zval_struct
+   ...
+}
+{
+   <suppress_false_positive_warning_see_v8_issue_6566_workarond_for_603286_extra>
+   Memcheck:Cond
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   obj:/opt/libv8-6.5/lib/libv8.so
+   fun:_ZL33zim_Isolate_lowMemoryNotificationP18_zend_execute_dataP12_zval_struct
+}

CMakeLists.txt

@@ -3,8 +3,8 @@ project(php-v8)
 
 # NOTE: This CMake file is just for syntax highlighting in CLion
 
-include_directories(/usr/local/opt/v8@6.4/include)
-include_directories(/usr/local/opt/v8@6.4/include/libplatform)
+include_directories(/usr/local/opt/v8@6.5/include)
+include_directories(/usr/local/opt/v8@6.5/include/libplatform)
 
 include_directories(/usr/local/include/php)
 include_directories(/usr/local/include/php/TSRM)

Dockerfile

@@ -1,4 +1,4 @@
-ARG TAG=xenial-v8-64-php-72
+ARG TAG=xenial-v8-65-php-72
 
 FROM pinepain/php-v8-docker:${TAG}
 

LICENSE

@@ -1,6 +1,6 @@
 The MIT License
 
-Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
+Copyright (c) 2015-2018 Bogdan Padalko <pinepain@gmail.com>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of
 this software and associated documentation files (the "Software"), to deal in

README.md

@@ -100,7 +100,7 @@ on top of php-v8 extension and makes embedding JavaScript in PHP easier.
 ### Requirements
 
 #### V8
-You will need a recent v8 Google JavaScript engine version installed. At this time v8 >= 6.4.6 required.
+You will need a recent v8 Google JavaScript engine version installed. At this time v8 >= 6.5.116 required.
 
 #### PHP
 This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
@@ -123,7 +123,7 @@ $ php --ri v8
 
 While [pinepain/php](https://launchpad.net/~pinepain/+archive/ubuntu/php) PPA targets to contain all necessary
 extensions with dependencies, you may find
-[pinepain/libv8-6.4](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.4),
+[pinepain/libv8-6.5](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.5),
 [pinepain/libv8-experimental](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-experimental) and
 [pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) standalone PPAs useful.
 
@@ -191,7 +191,7 @@ My thanks to the following people and projects, without whom this extension woul
 
 ## License
 
-Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
+Copyright (c) 2015-2018 Bogdan Padalko <pinepain@gmail.com>
 
 [php-v8](https://github.com/pinepain/php-v8) PHP extension is licensed under the [MIT license](http://opensource.org/licenses/MIT).
 

config.m4

@@ -19,7 +19,7 @@ if test "$PHP_V8" != "no"; then
   SEARCH_PATH="/usr/local /usr"
   SEARCH_FOR="include/v8.h"
 
-  V8_MIN_API_VERSION_STR=6.4.6
+  V8_MIN_API_VERSION_STR=6.5.116
 
   DESIRED_V8_VERSION=`echo "${V8_MIN_API_VERSION_STR}" | $AWK 'BEGIN { FS = "."; } { printf "%s.%s", [$]1, [$]2;}'`
 

docs/development/release-libv8.md

@@ -29,7 +29,8 @@ To track v8 changes you can use these links:
    been rebuild on push as we don't need them anymore and replace them with a new one (we still need to keep old tags
    for CI purpose and just in case things won't go smooth and we have to rollback).
 5. Rebuild/publish docker images to include new `libv8` version.
-6. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
+6. You may want to set proper default image `TAG` in `php-v8` `Dockerfile` by updating it first line `ARG TAG=xenial-v8-64-php-72`.
+7. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
 
 ## After docker images rebuilt/published
 

package.xml

@@ -2,7 +2,7 @@
 <!--
   ~ This file is part of the pinepain/php-v8 PHP extension.
   ~
-  ~ Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
+  ~ Copyright (c) 2015-2018 Bogdan Padalko <pinepain@gmail.com>
   ~
   ~ Licensed under the MIT license: http://opensource.org/licenses/MIT
   ~

perf/src/CreatePrimitiveValue.php

@@ -3,7 +3,7 @@
 /**
  * This file is part of the pinepain/php-v8 PHP extension.
  *
- * Copyright (c) 2015-2017 Bogdan Padalko <pinepain@gmail.com>
+ * Copyright (c) 2015-2018 Bogdan Padalko <pinepain@gmail.com>
  *
  * Licensed under the MIT license: http://opensource.org/licenses/MIT
  *