Move to dockerized libv8

Author: pinepain

.travis.yml

@@ -6,17 +6,21 @@ services:
 
 env:
   global:
-    - V8=6.5
+    - V8=6.5.144
   matrix:
-    - TAG=xenial-v8-65-php-71
-    - TAG=xenial-v8-65-php-71 TEST_PHP_ARGS=-m
-    - TAG=xenial-v8-65-php-72
-    - TAG=xenial-v8-65-php-72 TEST_PHP_ARGS=-m
+    - PHP=7.2
+    - PHP=7.2 TEST_PHP_ARGS=-m
+    - PHP=7.1
+    - PHP=7.1 TEST_PHP_ARGS=-m
 
 before_install:
   # docker on travis doesn't allow anything before FROM, let's fix that
-  - sed -i -e "s/\${TAG}/$TAG/g" Dockerfile && sed -i -e '1,2d' Dockerfile
-  - docker build -t ${TRAVIS_REPO_SLUG}:${V8}-${PHP} --build-arg TAG=${TAG} .
+  - sed -i -e "s/:latest/:${V8}/g" Dockerfile
+  - docker build -t ${TRAVIS_REPO_SLUG} --build-arg PHP=${PHP} .
 
 script:
-  - docker run -e TEST_PHP_ARGS ${TRAVIS_REPO_SLUG}:${V8}-${PHP} bash -c "make test | tee result.txt; ./test-report.sh"
+  - docker run
+    -e TEST_PHP_ARGS
+    -v `pwd`:/root/php-v8
+    ${TRAVIS_REPO_SLUG}
+    bash -c "phpize && ./configure && make test | tee result.txt; ./test-report.sh"

Dockerfile

@@ -1,13 +1,28 @@
-ARG TAG=xenial-v8-65-php-72
+FROM pinepain/libv8:latest
 
-FROM pinepain/php-v8-docker:${TAG}
+ARG PHP=7.2
+
+ENV DEBIAN_FRONTEND noninteractive
+ENV TERM=xterm-256color
+ENV LC_ALL=C.UTF-8
+ENV NO_INTERACTION=1
+ENV REPORT_EXIT_STATUS=1
+
+RUN echo "deb http://ppa.launchpad.net/ondrej/php/ubuntu xenial main" > /etc/apt/sources.list.d/ondrej-php-xenial.list && \
+    apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 4F4EA0AAE5267A6C && \
+    apt-get update && \
+    apt-get install -y valgrind && \
+    apt-get install -y php${PHP} php${PHP}-cli php${PHP}-dev php${PHP}-fpm && \
+    rm -rf /var/lib/apt/lists/* && \
+    echo 'variables_order = "EGPCS"' >> `php --ini | grep "Loaded Configuration File" | awk '{print $4}'` && \
+    php -i && \
+    php-config || true && \
+    mkdir /root/php-v8
 
-COPY . /root/php-v8
 COPY ./scripts/provision/.bashrc /root/.bashrc
 
 WORKDIR /root/php-v8
 
-ENV NO_INTERACTION=1
+#COPY . /root/php-v8
+#RUN phpize && ./configure && make
 
-RUN php -i && php-config || true
-RUN phpize && ./configure && make

README.md

@@ -167,6 +167,15 @@ $ sudo make install
  - [pinepain/libv8-experimental](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-experimental) normally contains
    `libv8` version that used in current `master` branch.
 
+### Docker
+
+First, let's build docker image `docker build -t pinepain/php-v8 .` that we'll use later for development. By default, 
+it contains PHP 7.2, though you can change that by passing `--build-arg PHP=MAJOR.MINOR` where MAJOR.MINOR version
+present in [ondrej/php](https://launchpad.net/~ondrej/+archive/ubuntu/php) PPA.
+
+To start playing with php-v8 in docker, run ```docker run -e TEST_PHP_ARGS -v `pwd`:/root/php-v8 -it pinepain/php-v8 bash``.
+Now you can build php-v8 as usual with `phpize && ./configure && make`. Don't forget to run `make test`!
+
 ### Docs
 
 To start writing docs you will need to get [GitBook](https://gitbook.com), just run `npm install gitbook-cli -g` and

config.m4

@@ -24,9 +24,9 @@ if test "$PHP_V8" != "no"; then
   DESIRED_V8_VERSION=`echo "${V8_MIN_API_VERSION_STR}" | $AWK 'BEGIN { FS = "."; } { printf "%s.%s", [$]1, [$]2;}'`
 
   # Path where v8 from packages we recommend are installed, it's /opt/libv8-MAJOR.MINOR on Ubuntu
-  # and /usr/local/opt/v8@MAJOR.MINOR on macOS
-  PRIORITY_SEARCH_PATH="/opt/libv8-${DESIRED_V8_VERSION} /usr/local/opt/v8@${DESIRED_V8_VERSION}"
-  SEARCH_PATH="${PRIORITY_SEARCH_PATH} /usr/local /usr"
+  # and /usr/local/opt/v8@MAJOR.MINOR on macOS. For Docker image it's just /opt/libv8
+  PRIORITY_SEARCH_PATH="/opt/libv8-${DESIRED_V8_VERSION} /usr/local/opt/v8@${DESIRED_V8_VERSION} /opt/libv8"
+  SEARCH_PATH="${PRIORITY_SEARCH_PATH} ${SEARCH_PATH}"
 
   if test -r $PHP_V8/$SEARCH_FOR; then
     V8_ROOT_DIR=$PHP_V8

docs/development/release-libv8.md

@@ -23,14 +23,10 @@ To track v8 changes you can use these links:
 1. Copy fresh `libv8-X.Y` build packages from `libv8-experimental` (default target for all libv8 builds we trigger)
    to it `libv8-X.Y` PPA. Do not rebuild, just copy binaries.
 2. **Wait for packages copied and published!**
-3. If there was a minor version bump in `libv8` (not patch), create new dockerfiles for it in
-   [php-v8-docker](https://github.com/pinepain/php-v8-docker) and set `ARG V8=X.Y` to proper version.
-4. Go to [php-v8-docker Docker Hub](https://hub.docker.com/r/pinepain/php-v8-docker) and remove old Docker tags from
-   been rebuild on push as we don't need them anymore and replace them with a new one (we still need to keep old tags
-   for CI purpose and just in case things won't go smooth and we have to rollback).
-5. Rebuild/publish docker images to include new `libv8` version.
-6. You may want to set proper default image `TAG` in `php-v8` `Dockerfile` by updating it first line `ARG TAG=xenial-v8-64-php-72`.
-7. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
+3. Build [libv8](https://github.com/pinepain/libv8) docker image, tag it with the relevant v8 full version and push to
+   Docker Hub.
+4. You may want to set proper `V8` version in `php-v8` by updating it in `.travis.yml`.
+5. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
 
 ## After docker images rebuilt/published