Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Commit 3b57c7a

Browse files
committed
Rename V8\Exceptions\AbstractResourceLimitException to V8\Exceptions\ResourceLimitException
1 parent 7e996c7 commit 3b57c7a

File tree

5 files changed

+10
-16
lines changed

5 files changed

+10
-16
lines changed

src/php_v8_exceptions.cc

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
zend_class_entry* php_v8_generic_exception_class_entry;
2323
zend_class_entry* php_v8_try_catch_exception_class_entry;
2424
zend_class_entry* php_v8_termination_exception_class_entry;
25-
zend_class_entry* php_v8_abstract_resource_limit_exception_class_entry;
25+
zend_class_entry* php_v8_resource_limit_exception_class_entry;
2626
zend_class_entry* php_v8_time_limit_exception_class_entry;
2727
zend_class_entry* php_v8_memory_limit_exception_class_entry;
2828

@@ -190,7 +190,7 @@ static const zend_function_entry php_v8_termination_exception_methods[] = {
190190
PHP_FE_END
191191
};
192192

193-
static const zend_function_entry php_v8_abstract_resource_limit_exception_methods[] = {
193+
static const zend_function_entry php_v8_resource_limit_exception_methods[] = {
194194
PHP_FE_END
195195
};
196196

@@ -202,11 +202,6 @@ static const zend_function_entry php_v8_memory_limit_exception_methods[] = {
202202
PHP_FE_END
203203
};
204204

205-
static const zend_function_entry php_v8_script_exception_methods[] = {
206-
PHP_FE_END
207-
};
208-
209-
210205
static const zend_function_entry php_v8_value_exception_methods[] = {
211206
PHP_FE_END
212207
};
@@ -229,15 +224,14 @@ PHP_MINIT_FUNCTION(php_v8_exceptions) {
229224
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "TerminationException", php_v8_termination_exception_methods);
230225
php_v8_termination_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_try_catch_exception_class_entry);
231226

232-
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "AbstractResourceLimitException", php_v8_abstract_resource_limit_exception_methods);
233-
php_v8_abstract_resource_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_termination_exception_class_entry);
234-
php_v8_abstract_resource_limit_exception_class_entry->ce_flags |= ZEND_ACC_EXPLICIT_ABSTRACT_CLASS;
227+
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "ResourceLimitException", php_v8_resource_limit_exception_methods);
228+
php_v8_resource_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_termination_exception_class_entry);
235229

236230
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "TimeLimitException", php_v8_time_limit_exception_methods);
237-
php_v8_time_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_abstract_resource_limit_exception_class_entry);
231+
php_v8_time_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_resource_limit_exception_class_entry);
238232

239233
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "MemoryLimitException", php_v8_memory_limit_exception_methods);
240-
php_v8_memory_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_abstract_resource_limit_exception_class_entry);
234+
php_v8_memory_limit_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_resource_limit_exception_class_entry);
241235

242236
INIT_NS_CLASS_ENTRY(ce, "V8\\Exceptions", "ValueException", php_v8_value_exception_methods);
243237
php_v8_value_exception_class_entry = zend_register_internal_class_ex(&ce, php_v8_generic_exception_class_entry);

src/php_v8_exceptions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ extern "C" {
3030
extern zend_class_entry* php_v8_generic_exception_class_entry;
3131
extern zend_class_entry* php_v8_try_catch_exception_class_entry;
3232
extern zend_class_entry* php_v8_termination_exception_class_entry;
33-
extern zend_class_entry* php_v8_abstract_resource_limit_exception_class_entry;
33+
extern zend_class_entry* php_v8_resource_limit_exception_class_entry;
3434
extern zend_class_entry* php_v8_time_limit_exception_class_entry;
3535
extern zend_class_entry* php_v8_memory_limit_exception_class_entry;
3636

stubs/src/Exceptions/MemoryLimitException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
namespace V8\Exceptions;
1717

1818

19-
class MemoryLimitException extends AbstractResourceLimitException
19+
class MemoryLimitException extends ResourceLimitException
2020
{
2121
}

stubs/src/Exceptions/AbstractResourceLimitException.php renamed to stubs/src/Exceptions/ResourceLimitException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
namespace V8\Exceptions;
1717

1818

19-
abstract class AbstractResourceLimitException extends TerminationException
19+
class ResourceLimitException extends TerminationException
2020
{
2121
}

stubs/src/Exceptions/TimeLimitException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
namespace V8\Exceptions;
1717

1818

19-
class TimeLimitException extends AbstractResourceLimitException
19+
class TimeLimitException extends ResourceLimitException
2020
{
2121
}

0 commit comments

Comments
 (0)