Drop non-working V8\Context extensions support

BC-break: removed $extensions argument from V8\Context constructor

Author: pinepain

src/php_v8_context.cc

@@ -89,15 +89,14 @@ php_v8_context_t * php_v8_context_get_reference(v8::Local<v8::Context> context)
 static PHP_METHOD(V8Context, __construct)
 {
     zval *php_v8_isolate_zv;
-    zval *extensions_zv = NULL;
     zval *php_v8_global_template_zv = NULL;
     zval *php_v8_global_object_zv = NULL;
 
     v8::ExtensionConfiguration *extensions = NULL;
     v8::Local<v8::ObjectTemplate> global_template;
     v8::Local<v8::Value> global_object;
 
-    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o|a!o!o!", &php_v8_isolate_zv, &extensions_zv, &php_v8_global_template_zv, &php_v8_global_object_zv) == FAILURE) {
+    if (zend_parse_parameters(ZEND_NUM_ARGS(), "o|o!o!", &php_v8_isolate_zv, &php_v8_global_template_zv, &php_v8_global_object_zv) == FAILURE) {
         return;
     }
 
@@ -108,20 +107,10 @@ static PHP_METHOD(V8Context, __construct)
     PHP_V8_STORE_POINTER_TO_ISOLATE(php_v8_context, php_v8_isolate);
     PHP_V8_ENTER_ISOLATE(php_v8_isolate);
 
-    if (extensions_zv) {
-        zend_update_property(this_ce, getThis(), ZEND_STRL("extensions"), extensions_zv);
-    }
-
     if (php_v8_global_template_zv) {
         zend_update_property(this_ce, getThis(), ZEND_STRL("global_template"), php_v8_global_template_zv);
     }
 
-    // TODO: implement extensions, note this feature is controversial, it also requires v8::RegisterExtension()
-    // TODO: store registered extensions somewhere and validate them by name before setting?
-    if (extensions_zv && zend_array_count(Z_ARRVAL_P(extensions_zv)) > 0) {
-        zend_error(E_WARNING, "Extensions are not supported yet");
-    }
-
     if (php_v8_global_template_zv && Z_TYPE_P(php_v8_global_template_zv) != IS_NULL) {
         PHP_V8_FETCH_OBJECT_TEMPLATE_WITH_CHECK(php_v8_global_template_zv, php_v8_global_template);
         PHP_V8_DATA_ISOLATES_CHECK(php_v8_context, php_v8_global_template);
@@ -308,7 +297,6 @@ static PHP_METHOD(V8Context, EstimatedSize)
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_v8_context___construct, ZEND_SEND_BY_VAL, ZEND_RETURN_VALUE, 1)
     ZEND_ARG_OBJ_INFO(0, isolate, V8\\Isolate, 0)
-    ZEND_ARG_ARRAY_INFO(0, extensions, 1)
     ZEND_ARG_OBJ_INFO(0, global_template, V8\\ObjectTemplate, 1)
     ZEND_ARG_OBJ_INFO(0, global_object, V8\\ObjectValue, 1)
 ZEND_END_ARG_INFO()
@@ -383,7 +371,6 @@ PHP_MINIT_FUNCTION(php_v8_context)
     this_ce->create_object = php_v8_context_ctor;
 
     zend_declare_property_null(this_ce, ZEND_STRL("isolate"), ZEND_ACC_PRIVATE);
-    zend_declare_property_null(this_ce, ZEND_STRL("extensions"), ZEND_ACC_PRIVATE);
     zend_declare_property_null(this_ce, ZEND_STRL("global_template"), ZEND_ACC_PRIVATE);
     zend_declare_property_null(this_ce, ZEND_STRL("global_object"), ZEND_ACC_PRIVATE);
 

stubs/src/Context.php

@@ -32,9 +32,6 @@ class Context
      *
      * \param isolate The isolate in which to create the context.
      *
-     * \param extensions An optional extension configuration containing
-     * the extensions to be installed in the newly created context.
-     *
      * \param global_template An optional object template from which the
      * global object for the newly created context will be created.
      *
@@ -45,15 +42,13 @@ class Context
      * and only object identify will remain.
      *
      * @param \V8\Isolate             $isolate
-     * @param array|null              $extensions Currently unused as there are not extensions support
      * @param \V8\ObjectTemplate|null $global_template
      * @param \V8\ObjectValue|null    $global_object
+     *
+     * @internal param array|null $extensions Currently unused as there are not extensions support
      */
     public function __construct(
-        Isolate $isolate,
-        array $extensions = null,
-        ObjectTemplate $global_template = null,
-        ObjectValue $global_object = null
+        Isolate $isolate, ObjectTemplate $global_template = null, ObjectValue $global_object = null
     ) {
     }
 

tests/003-V8ObjectTemplate_recursive_global.phpt

@@ -25,7 +25,7 @@ try {
     $helper->exception_export($e);
 }
 
-$context = new \V8\Context($isolate, [], $template);
+$context = new \V8\Context($isolate, $template);
 
 
 ?>

tests/V8ArrayObject.phpt

@@ -12,11 +12,10 @@ require '.v8-helpers.php';
 $v8_helper = new PhpV8Helpers($helper);
 
 $isolate = new \V8\Isolate();
-$extensions1 = [];
 $global_template1 = new V8\ObjectTemplate($isolate);
 
 $global_template1->Set(new \V8\StringValue($isolate, 'print'), $v8_helper->getPrintFunctionTemplate($isolate), \V8\PropertyAttribute::DontDelete);
-$context = new V8\Context($isolate, $extensions1, $global_template1);
+$context = new V8\Context($isolate, $global_template1);
 
 $value = new V8\ArrayObject($context);
 
@@ -81,7 +80,7 @@ object(V8\ArrayObject)#6 (2) {
     bool(false)
   }
   ["context":"V8\ObjectValue":private]=>
-  object(V8\Context)#5 (4) {
+  object(V8\Context)#5 (3) {
     ["isolate":"V8\Context":private]=>
     object(V8\Isolate)#3 (5) {
       ["snapshot":"V8\Isolate":private]=>
@@ -95,9 +94,6 @@ object(V8\ArrayObject)#6 (2) {
       ["memory_limit_hit":"V8\Isolate":private]=>
       bool(false)
     }
-    ["extensions":"V8\Context":private]=>
-    array(0) {
-    }
     ["global_template":"V8\Context":private]=>
     object(V8\ObjectTemplate)#4 (1) {
       ["isolate":"V8\Template":private]=>
@@ -267,7 +263,7 @@ V8\ArrayObject(V8\Value)->ToObject():
         bool(false)
       }
       ["context":"V8\ObjectValue":private]=>
-      object(V8\Context)#5 (4) {
+      object(V8\Context)#5 (3) {
         ["isolate":"V8\Context":private]=>
         object(V8\Isolate)#3 (5) {
           ["snapshot":"V8\Isolate":private]=>
@@ -281,9 +277,6 @@ V8\ArrayObject(V8\Value)->ToObject():
           ["memory_limit_hit":"V8\Isolate":private]=>
           bool(false)
         }
-        ["extensions":"V8\Context":private]=>
-        array(0) {
-        }
         ["global_template":"V8\Context":private]=>
         object(V8\ObjectTemplate)#4 (1) {
           ["isolate":"V8\Template":private]=>

tests/V8ArrayObject_Length.phpt

@@ -9,10 +9,9 @@ V8\ArrayObject::Length
 $helper = require '.testsuite.php';
 
 $isolate1 = new \V8\Isolate();
-$extensions1 = [];
 $global_template1 = new V8\ObjectTemplate($isolate1);
 
-$context1 = new V8\Context($isolate1, $extensions1, $global_template1);
+$context1 = new V8\Context($isolate1, $global_template1);
 
 $source1    = '
 [1,2,3]

tests/V8Boolean.phpt

@@ -33,9 +33,8 @@ $helper->space();
 
 $v8_helper->run_checks($value, 'Checkers');
 
-$extensions = [];
 $global_template = new \V8\ObjectTemplate($isolate);
-$context = new \V8\Context($isolate, $extensions, $global_template);
+$context = new \V8\Context($isolate, $global_template);
 
 
 $helper->header('Primitive converters');

tests/V8BooleanObject.phpt

@@ -12,15 +12,14 @@ require '.v8-helpers.php';
 $v8_helper = new PhpV8Helpers($helper);
 
 $isolate1 = new \V8\Isolate();
-$extensions1 = [];
 $global_template1 = new V8\ObjectTemplate($isolate1);
 
 // TODO: fix it, this cause segfault due to FunctionTemplate object destruction and all it internal structures cleanup
 //$global_template1->Set('print', $v8_helper->getPrintFunctionTemplate($isolate1), \V8\PropertyAttribute::DontDelete);
 $print_func_tpl = $v8_helper->getPrintFunctionTemplate($isolate1);
 $global_template1->Set(new \V8\StringValue($isolate1, 'print'), $print_func_tpl, \V8\PropertyAttribute::DontDelete);
 
-$context1 = new V8\Context($isolate1, $extensions1, $global_template1);
+$context1 = new V8\Context($isolate1, $global_template1);
 
 $value = new V8\BooleanObject($context1, true);
 
@@ -73,7 +72,7 @@ object(V8\BooleanObject)#8 (2) {
     bool(false)
   }
   ["context":"V8\ObjectValue":private]=>
-  object(V8\Context)#7 (4) {
+  object(V8\Context)#7 (3) {
     ["isolate":"V8\Context":private]=>
     object(V8\Isolate)#3 (5) {
       ["snapshot":"V8\Isolate":private]=>
@@ -87,9 +86,6 @@ object(V8\BooleanObject)#8 (2) {
       ["memory_limit_hit":"V8\Isolate":private]=>
       bool(false)
     }
-    ["extensions":"V8\Context":private]=>
-    array(0) {
-    }
     ["global_template":"V8\Context":private]=>
     object(V8\ObjectTemplate)#4 (1) {
       ["isolate":"V8\Template":private]=>

tests/V8Context.phpt

@@ -12,15 +12,6 @@ require '.v8-helpers.php';
 $v8_helper = new PhpV8Helpers($helper);
 
 $isolate1 = new \V8\Isolate();
-$extensions1 = [];
-//$global_template1 = new V8\ObjectTemplate($isolate1);
-//$global_template1->Set('print', $v8_helper->getPrintFunctionTemplate($isolate1), \V8\PropertyAttribute::DontDelete);
-
-try{
-    $context = new \V8\Context($isolate1, ['some', 'extensions']);
-} catch(Exception $e) {
-    $helper->exception_export($e);
-}
 
 $context = new \V8\Context($isolate1);
 $helper->pretty_dump('Estimated memory usage size by this context', $context->EstimatedSize());
@@ -50,7 +41,6 @@ $helper->pretty_dump('Estimated memory usage size by this context', $context->Es
 
 ?>
 --EXPECTF--
-ErrorException: Extensions are not supported yet
 Estimated memory usage size by this context: int(%d)
 V8\Context::GlobalObject() result is instance of V8\ObjectValue
 CHECK $global->SameValue($context->GlobalObject()): OK

tests/V8Context_GlobalObject.phpt

@@ -15,8 +15,6 @@ $v8_helper = new PhpV8Helpers($helper);
 require '.tracking_dtors.php';
 
 $isolate1 = new \V8\Isolate();
-$extensions1 = [];
-
 $context = new \V8\Context($isolate1);
 
 $helper->method_matches_instanceof($context, 'GlobalObject', \V8\ObjectValue::class);
@@ -31,7 +29,7 @@ $helper->assert('Global object on repeatable calls holds extra props', $global1-
 
 $context->DetachGlobal();
 
-$context2 = new \V8\Context($isolate1, null, null, $global2);
+$context2 = new \V8\Context($isolate1, null, $global2);
 $helper->method_matches_instanceof($context2, 'GlobalObject', \V8\ObjectValue::class);
 
 echo 'Global object passed from one context to another is ', ($global1 === $global2 ? 'the same' : 'not the same'), PHP_EOL;

tests/V8Context_weakness.phpt

@@ -17,15 +17,14 @@ class Context extends V8\Context {
 }
 
 $isolate1 = new \V8\Isolate();
-$extensions1 = [];
 
 $global_template1 = new V8\ObjectTemplate($isolate1);
 
 $source1 = 'var obj = {}; obj';
 $file_name1 = 'test.js';
 
 $script1 = new \V8\Script(
-    new Context($isolate1, $extensions1, $global_template1),
+    new Context($isolate1, $global_template1),
     new \V8\StringValue($isolate1, $source1),
     new \V8\ScriptOrigin($file_name1)
 );