Upgrade to libv8 6.5.116

Author: pinepain

.travis.yml

@@ -6,12 +6,12 @@ services:
 
 env:
   global:
-    - V8=6.4
+    - V8=6.5
   matrix:
-    - TAG=xenial-v8-64-php-71
-    - TAG=xenial-v8-64-php-71 TEST_PHP_ARGS=-m
-    - TAG=xenial-v8-64-php-72
-    - TAG=xenial-v8-64-php-72 TEST_PHP_ARGS=-m
+    - TAG=xenial-v8-65-php-71
+    - TAG=xenial-v8-65-php-71 TEST_PHP_ARGS=-m
+    - TAG=xenial-v8-65-php-72
+    - TAG=xenial-v8-65-php-72 TEST_PHP_ARGS=-m
 
 before_install:
   # docker on travis doesn't allow anything before FROM, let's fix that

CMakeLists.txt

@@ -3,8 +3,8 @@ project(php-v8)
 
 # NOTE: This CMake file is just for syntax highlighting in CLion
 
-include_directories(/usr/local/opt/v8@6.4/include)
-include_directories(/usr/local/opt/v8@6.4/include/libplatform)
+include_directories(/usr/local/opt/v8@6.5/include)
+include_directories(/usr/local/opt/v8@6.5/include/libplatform)
 
 include_directories(/usr/local/include/php)
 include_directories(/usr/local/include/php/TSRM)

Dockerfile

@@ -1,4 +1,4 @@
-ARG TAG=xenial-v8-64-php-72
+ARG TAG=xenial-v8-65-php-72
 
 FROM pinepain/php-v8-docker:${TAG}
 

README.md

@@ -100,7 +100,7 @@ on top of php-v8 extension and makes embedding JavaScript in PHP easier.
 ### Requirements
 
 #### V8
-You will need a recent v8 Google JavaScript engine version installed. At this time v8 >= 6.4.6 required.
+You will need a recent v8 Google JavaScript engine version installed. At this time v8 >= 6.5.116 required.
 
 #### PHP
 This extension is PHP7-only. It works and tested with both PHP 7.0 and PHP 7.1.
@@ -123,7 +123,7 @@ $ php --ri v8
 
 While [pinepain/php](https://launchpad.net/~pinepain/+archive/ubuntu/php) PPA targets to contain all necessary
 extensions with dependencies, you may find
-[pinepain/libv8-6.4](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.4),
+[pinepain/libv8-6.5](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-6.5),
 [pinepain/libv8-experimental](https://launchpad.net/~pinepain/+archive/ubuntu/libv8-experimental) and
 [pinepain/php-v8](https://launchpad.net/~pinepain/+archive/ubuntu/php-v8) standalone PPAs useful.
 

config.m4

@@ -19,7 +19,7 @@ if test "$PHP_V8" != "no"; then
   SEARCH_PATH="/usr/local /usr"
   SEARCH_FOR="include/v8.h"
 
-  V8_MIN_API_VERSION_STR=6.4.6
+  V8_MIN_API_VERSION_STR=6.5.116
 
   DESIRED_V8_VERSION=`echo "${V8_MIN_API_VERSION_STR}" | $AWK 'BEGIN { FS = "."; } { printf "%s.%s", [$]1, [$]2;}'`
 

docs/development/release-libv8.md

@@ -29,7 +29,8 @@ To track v8 changes you can use these links:
    been rebuild on push as we don't need them anymore and replace them with a new one (we still need to keep old tags
    for CI purpose and just in case things won't go smooth and we have to rollback).
 5. Rebuild/publish docker images to include new `libv8` version.
-6. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
+6. You may want to set proper default image `TAG` in `php-v8` `Dockerfile` by updating it first line `ARG TAG=xenial-v8-64-php-72`.
+7. Make sure you have proper `php-v8` version set in `packaging/Dockerfile` under `V8` constant. 
 
 ## After docker images rebuilt/published
 

scripts/provision/provision.sh

@@ -5,7 +5,7 @@ echo Provisioning...
 # Add Ondřej Surý's PPA with co-installable PHP versions:
 sudo add-apt-repository -y ppa:ondrej/php
 # Add libv8 PPA:
-sudo add-apt-repository ppa:pinepain/libv8-6.4
+sudo add-apt-repository ppa:pinepain/libv8-6.5
 
 # Let's update packages list:
 sudo apt-get update
@@ -19,10 +19,10 @@ sudo apt-get install -y git htop curl pkgconf
 
 
 # Build and development requirements
-sudo apt-get install -y libv8-6.4 libv8-6.4-dev libv8-6.4-dbg
+sudo apt-get install -y libv8-6.5 libv8-6.5-dev libv8-6.5-dbg
 sudo apt-get install -y dh-make valgrind
 sudo apt-get install -y libssl-dev openssl
-sudo apt-get install -y php7.1 php7.1-cli php7.1-dev php7.1-fpm
+sudo apt-get install -y php7.2 php7.2-cli php7.2-dev php7.2-fpm
 sudo apt-get install -y php-pear autoconf automake curl libcurl3-openssl-dev build-essential libxslt1-dev re2c libxml2 libxml2-dev bison libbz2-dev libreadline-dev
 sudo apt-get install -y libfreetype6 libfreetype6-dev libpng12-0 libpng12-dev libjpeg-dev libjpeg8-dev libjpeg8  libgd-dev libgd3 libxpm4 libltdl7 libltdl-dev
 sudo apt-get install -y libssl-dev openssl gettext libgettextpo-dev libgettextpo0 libicu-dev libmhash-dev libmhash2 libmcrypt-dev libmcrypt4

scripts/test_v8/hello_world.cpp

@@ -6,17 +6,6 @@
 
 using namespace v8;
 
-class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
-public:
-  virtual void* Allocate(size_t length) {
-    void* data = AllocateUninitialized(length);
-    return data == NULL ? data : memset(data, 0, length);
-  }
-  virtual void* AllocateUninitialized(size_t length) { return malloc(length); }
-  virtual void Free(void* data, size_t) { free(data); }
-};
-
-
 void weak_callback(const v8::WeakCallbackInfo<v8::Persistent<v8::String>>& data) {
   printf("Weak callback called\n");
   data.GetParameter()->Reset();
@@ -29,20 +18,16 @@ int main(int argc, char* argv[]) {
   v8::Platform *platform = v8::platform::CreateDefaultPlatform();
   v8::V8::InitializePlatform(platform);
 
-  V8::Initialize();
-
+//  std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
+//  v8::V8::InitializePlatform(platform.get());
 
-  ArrayBufferAllocator *array_buffer_allocator;
-  v8::Isolate::CreateParams *create_params;
-
-  array_buffer_allocator = new ArrayBufferAllocator();
-  create_params = new v8::Isolate::CreateParams();
-
-  create_params->array_buffer_allocator = array_buffer_allocator;
+  V8::Initialize();
 
+  v8::Isolate::CreateParams create_params;
+  create_params.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
 
   // Create a new Isolate and make it the current one.
-  Isolate* isolate = v8::Isolate::New(*create_params);
+  Isolate* isolate = v8::Isolate::New(create_params);
 
   v8::Persistent<v8::String> test;
 
@@ -90,9 +75,5 @@ int main(int argc, char* argv[]) {
   V8::Dispose();
   V8::ShutdownPlatform();
 
-  delete array_buffer_allocator;
-  delete create_params;
-  delete platform;
-
   return 0;
 }

scripts/test_v8/hello_world_build_deb.sh

@@ -1,18 +1,20 @@
 #!/bin/bash
 
-ROOT=/opt/libv8-6.2
+ROOT=/opt/libv8-6.5
 LIB_DIR=$ROOT/lib/
 
 SRC_DIR=$ROOT
 INCLUDE_DIR=$ROOT/include
 
-g++ hello_world.cpp -o hello_world \
+set -x
+
+g++ -std=c++14 hello_world.cpp -o hello_world \
  -g \
  -O2 \
  -std=c++11 \
- -I$SRC_DIR \
  -I$INCLUDE_DIR \
  -L$LIB_DIR \
+ -Wl,-rpath,$LIB_DIR \
  -lv8_libbase \
  -lv8_libplatform \
  -lv8 \

scripts/test_v8/hello_world_build_osx.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=/usr/local/opt/v8@6.2
+ROOT=/usr/local/opt/v8@6.5
 LIB_DIR=$ROOT/lib/
 
 SRC_DIR=$ROOT