OperatorRuleHelper - allow mixed

Author: ondrejmirtes

src/Rules/Operators/OperatorRuleHelper.php

@@ -4,6 +4,7 @@
 
 use PHPStan\Type\FloatType;
 use PHPStan\Type\IntegerType;
+use PHPStan\Type\MixedType;
 use PHPStan\Type\Type;
 use PHPStan\Type\UnionType;
 
@@ -12,6 +13,10 @@ class OperatorRuleHelper
 
 	public static function isValidForArithmeticOperation(Type $leftType, Type $rightType): bool
 	{
+		if ($leftType instanceof MixedType || $rightType instanceof MixedType) {
+			return true;
+		}
+
 		$acceptedType = new UnionType([new IntegerType(), new FloatType()]);
 
 		return $acceptedType->isSuperTypeOf($leftType)->yes() && $acceptedType->isSuperTypeOf($rightType)->yes();

tests/Rules/Operators/OperandsInArithmeticAdditionTest.php

@@ -43,14 +43,6 @@ public function testRule(): void
 				'Only numeric types or arrays are allowed in arithmetic addition.',
 				30,
 			],
-			[
-				'Only numeric types or arrays are allowed in arithmetic addition.',
-				30,
-			],
-			[
-				'Only numeric types or arrays are allowed in arithmetic addition.',
-				30,
-			],
 		]);
 	}
 

tests/Rules/Operators/OperandsInArithmeticDivisionTest.php

@@ -43,14 +43,6 @@ public function testRule(): void
 				'Only numeric types are allowed in arithmetic division.',
 				69,
 			],
-			[
-				'Only numeric types are allowed in arithmetic division.',
-				69,
-			],
-			[
-				'Only numeric types are allowed in arithmetic division.',
-				69,
-			],
 		]);
 	}
 

tests/Rules/Operators/OperandsInArithmeticExponentiationTest.php

@@ -43,10 +43,6 @@ public function testRule(): void
 				'Only numeric types are allowed in arithmetic exponentiation.',
 				82,
 			],
-			[
-				'Only numeric types are allowed in arithmetic exponentiation.',
-				82,
-			],
 		]);
 	}
 

tests/Rules/Operators/OperandsInArithmeticMultiplicationTest.php

@@ -43,14 +43,6 @@ public function testRule(): void
 				'Only numeric types are allowed in arithmetic multiplication.',
 				56,
 			],
-			[
-				'Only numeric types are allowed in arithmetic multiplication.',
-				56,
-			],
-			[
-				'Only numeric types are allowed in arithmetic multiplication.',
-				56,
-			],
 		]);
 	}
 

tests/Rules/Operators/OperandsInArithmeticSubtractionTest.php

@@ -43,14 +43,6 @@ public function testRule(): void
 				'Only numeric types are allowed in arithmetic subtraction.',
 				43,
 			],
-			[
-				'Only numeric types are allowed in arithmetic subtraction.',
-				43,
-			],
-			[
-				'Only numeric types are allowed in arithmetic subtraction.',
-				43,
-			],
 		]);
 	}
 

tests/Rules/Operators/data/operators.php

@@ -93,3 +93,9 @@
 $int % $null;
 $int % $float % $string % $null;
 $array % $float % $array % $int;
+
+function ($mixed, int $a) {
+	$mixed + $mixed;
+	$mixed + $a;
+	$a + $mixed;
+};