-
Notifications
You must be signed in to change notification settings - Fork 547
Implement InterpolatedStringHandler #4600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+112
−0
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
90 changes: 90 additions & 0 deletions
90
src/Analyser/Generator/ExprHandler/InterpolatedStringHandler.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| <?php declare(strict_types = 1); | ||
|
|
||
| namespace PHPStan\Analyser\Generator\ExprHandler; | ||
|
|
||
| use Generator; | ||
| use PhpParser\Node\Expr; | ||
| use PhpParser\Node\InterpolatedStringPart; | ||
| use PhpParser\Node\Scalar\InterpolatedString; | ||
| use PhpParser\Node\Stmt; | ||
| use PHPStan\Analyser\ExpressionContext; | ||
| use PHPStan\Analyser\Generator\ExprAnalysisRequest; | ||
| use PHPStan\Analyser\Generator\ExprAnalysisResult; | ||
| use PHPStan\Analyser\Generator\ExprHandler; | ||
| use PHPStan\Analyser\Generator\GeneratorScope; | ||
| use PHPStan\Analyser\Generator\NoopNodeCallback; | ||
| use PHPStan\Analyser\SpecifiedTypes; | ||
| use PHPStan\DependencyInjection\AutowiredService; | ||
| use PHPStan\Reflection\InitializerExprTypeResolver; | ||
| use PHPStan\Type\Constant\ConstantStringType; | ||
| use function array_merge; | ||
|
|
||
| /** | ||
| * @implements ExprHandler<InterpolatedString> | ||
| */ | ||
| #[AutowiredService] | ||
| final class InterpolatedStringHandler implements ExprHandler | ||
| { | ||
|
|
||
| public function __construct(private InitializerExprTypeResolver $initializerExprTypeResolver) | ||
| { | ||
| } | ||
|
|
||
| public function supports(Expr $expr): bool | ||
| { | ||
| return $expr instanceof InterpolatedString; | ||
| } | ||
|
|
||
| public function analyseExpr( | ||
| Stmt $stmt, | ||
| Expr $expr, | ||
| GeneratorScope $scope, | ||
| ExpressionContext $context, | ||
| ?callable $alternativeNodeCallback, | ||
| ): Generator | ||
| { | ||
| yield from []; | ||
|
|
||
| $resultType = null; | ||
| $hasYield = false; | ||
| $throwPoints = []; | ||
| $impurePoints = []; | ||
| $isAlwaysTerminating = false; | ||
| foreach ($expr->parts as $part) { | ||
| if ($part instanceof InterpolatedStringPart) { | ||
| $partType = new ConstantStringType($part->value); | ||
| } else { | ||
| $result = yield new ExprAnalysisRequest($stmt, $part, $scope, $context->enterDeep(), new NoopNodeCallback()); | ||
| $partType = $result->type->toString(); | ||
|
|
||
| $hasYield = $hasYield || $result->hasYield; | ||
| $throwPoints = array_merge($throwPoints, $result->throwPoints); | ||
| $impurePoints = array_merge($impurePoints, $result->impurePoints); | ||
| $isAlwaysTerminating = $isAlwaysTerminating || $result->isAlwaysTerminating; | ||
| $scope = $result->scope; | ||
| } | ||
|
|
||
| if ($resultType === null) { | ||
| $resultType = $partType; | ||
| continue; | ||
| } | ||
|
|
||
| $resultType = $this->initializerExprTypeResolver->resolveConcatType($resultType, $partType); | ||
| } | ||
|
|
||
| $type = $resultType ?? new ConstantStringType(''); | ||
| return new ExprAnalysisResult( | ||
| $type, | ||
| $type, | ||
|
||
| $scope, | ||
| hasYield: $hasYield, | ||
| isAlwaysTerminating: $isAlwaysTerminating, | ||
| throwPoints: $throwPoints, | ||
| impurePoints: $impurePoints, | ||
| specifiedTruthyTypes: new SpecifiedTypes(), | ||
| specifiedFalseyTypes: new SpecifiedTypes(), | ||
| specifiedNullTypes: new SpecifiedTypes(), | ||
| ); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is noop-correct here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. It'd mean that for
$partno rule is executed.NoopNodeCallbackis the equivalent ofstatic function () {}when calling->processExprNodeor->processStmtNodein NodeScopeResolver.So it's used when we want a result of a synthetic node (where we do
new SomeAstNode(...)because we're interested in the result but otherwise the node is not in the original source so it would not make sense to report errors on it).Also we'd use
NoopNodeCallbackwhen we need ExprAnalysisRequest for something that we're sure has already been analysed. Thanks tophpstan-src/src/Analyser/Generator/GeneratorNodeScopeResolver.php
Lines 470 to 472 in 3bd2d8b