Implement InterpolatedStringHandler

[staabm]

as in

• phpstan-src/src/Analyser/MutatingScope.php

  Lines 1262 to 1276 in 6cf0ab2

  	} elseif ($node instanceof Node\Scalar\InterpolatedString) {
  	$resultType = null;
  	foreach ($node->parts as $part) {
  	if ($part instanceof InterpolatedStringPart) {
  	$partType = new ConstantStringType($part->value);
  	} else {
  	$partType = $this->getType($part)->toString();
  	}
  	if ($resultType === null) {
  	$resultType = $partType;
  	continue;
  	}
  	$resultType = $this->initializerExprTypeResolver->resolveConcatType($resultType, $partType);
  	}

• phpstan-src/src/Analyser/NodeScopeResolver.php

  Lines 3399 to 3414 in 6cf0ab2

  	} elseif ($expr instanceof Node\Scalar\InterpolatedString) {
  	$hasYield = false;
  	$throwPoints = [];
  	$impurePoints = [];
  	$isAlwaysTerminating = false;
  	foreach ($expr->parts as $part) {
  	if (!$part instanceof Expr) {
  	continue;
  	}
  	$result = $this->processExprNode($stmt, $part, $scope, $nodeCallback, $context->enterDeep());
  	$hasYield = $hasYield || $result->hasYield();
  	$throwPoints = array_merge($throwPoints, $result->getThrowPoints());
  	$impurePoints = array_merge($impurePoints, $result->getImpurePoints());
  	$isAlwaysTerminating = $isAlwaysTerminating || $result->isAlwaysTerminating();
  	$scope = $result->getScope();
  	}

[staabm]

is noop-correct here?

[ondrejmirtes]

I don't think so. It'd mean that for $part no rule is executed. NoopNodeCallback is the equivalent of static function () {} when calling ->processExprNode or ->processStmtNode in NodeScopeResolver.

So it's used when we want a result of a synthetic node (where we do new SomeAstNode(...) because we're interested in the result but otherwise the node is not in the original source so it would not make sense to report errors on it).

Also we'd use NoopNodeCallback when we need ExprAnalysisRequest for something that we're sure has already been analysed. Thanks to

phpstan-src/src/Analyser/Generator/GeneratorNodeScopeResolver.php

Lines 470 to 472 in 3bd2d8b

	if ($alternativeNodeCallback instanceof NoopNodeCallback) {
	return $foundExprAnalysisResult;
	}

it'd just return the result instead of throwing an exception.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

I don't think so. It'd mean that for $part no rule is executed. NoopNodeCallback is the equivalent of static function () {} when calling ->processExprNode or ->processStmtNode in NodeScopeResolver.

So it's used when we want a result of a synthetic node (where we do new SomeAstNode(...) because we're interested in the result but otherwise the node is not in the original source so it would not make sense to report errors on it).

Also we'd use NoopNodeCallback when we need ExprAnalysisRequest for something that we're sure has already been analysed. Thanks to

phpstan-src/src/Analyser/Generator/GeneratorNodeScopeResolver.php

Lines 470 to 472 in 3bd2d8b

	if ($alternativeNodeCallback instanceof NoopNodeCallback) {
	return $foundExprAnalysisResult;
	}

it'd just return the result instead of throwing an exception.

[ondrejmirtes]

What about native type here? :)

[ondrejmirtes]

Thank you!