Add pureUnlessCallableIsImpureParameters

zonuexe · zonuexe · commit e99305e9cab9 · 2025-08-01T21:26:00.000+09:00
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -3088,6 +3088,7 @@ public function enterTrait(ClassReflection $traitReflection): self
 	 * @param Type[] $parameterOutTypes
 	 * @param array<string, bool> $immediatelyInvokedCallableParameters
 	 * @param array<string, Type> $phpDocClosureThisTypeParameters
+	 * @param array<string, bool> $phpDocPureUnlessCallableIsImpureParameters
 	 */
 	public function enterClassMethod(
 		Node\Stmt\ClassMethod $classMethod,
@@ -3108,6 +3109,7 @@ public function enterClassMethod(
 		array $immediatelyInvokedCallableParameters = [],
 		array $phpDocClosureThisTypeParameters = [],
 		bool $isConstructor = false,
+		array $phpDocPureUnlessCallableIsImpureParameters = [],
 	): self
 	{
 		if (!$this->isInClass()) {
@@ -3142,6 +3144,7 @@ public function enterClassMethod(
 				array_map(fn (Type $type): Type => $this->transformStaticType(TemplateTypeHelper::toArgument($type)), $phpDocClosureThisTypeParameters),
 				$isConstructor,
 				$this->attributeReflectionFactory->fromAttrGroups($classMethod->attrGroups, InitializerExprContext::fromStubParameter($this->getClassReflection()->getName(), $this->getFile(), $classMethod)),
+				$phpDocPureUnlessCallableIsImpureParameters,
 			),
 			!$classMethod->isStatic(),
 		);
@@ -3319,6 +3322,7 @@ private function getParameterAttributes(ClassMethod|Function_|PropertyHook $func
 	 * @param Type[] $parameterOutTypes
 	 * @param array<string, bool> $immediatelyInvokedCallableParameters
 	 * @param array<string, Type> $phpDocClosureThisTypeParameters
+	 * @param array<string, bool> $pureUnlessCallableIsImpureParameters
 	 */
 	public function enterFunction(
 		Node\Stmt\Function_ $function,
@@ -3336,6 +3340,7 @@ public function enterFunction(
 		array $parameterOutTypes = [],
 		array $immediatelyInvokedCallableParameters = [],
 		array $phpDocClosureThisTypeParameters = [],
+		array $pureUnlessCallableIsImpureParameters = [],
 	): self
 	{
 		return $this->enterFunctionLike(
@@ -3361,6 +3366,7 @@ public function enterFunction(
 				$immediatelyInvokedCallableParameters,
 				$phpDocClosureThisTypeParameters,
 				$this->attributeReflectionFactory->fromAttrGroups($function->attrGroups, InitializerExprContext::fromStubParameter(null, $this->getFile(), $function)),
+				$pureUnlessCallableIsImpureParameters,
 			),
 			false,
 		);
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -651,7 +651,7 @@ private function processStmtNode(
 			$throwPoints = [];
 			$impurePoints = [];
 			$this->processAttributeGroups($stmt, $stmt->attrGroups, $scope, $nodeCallback);
-			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->getPhpDocs($scope, $stmt);
+			[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes, $pureUnlessCallableIsImpureParameters] = $this->getPhpDocs($scope, $stmt);
 
 			foreach ($stmt->params as $param) {
 				$this->processParamNode($stmt, $param, $scope, $nodeCallback);
@@ -6664,7 +6664,7 @@ private function processNodesForCalledMethod($node, string $fileName, MethodRefl
 	}
 
 	/**
-	 * @return array{TemplateTypeMap, array<string, Type>, array<string, bool>, array<string, Type>, ?Type, ?Type, ?string, bool, bool, bool, bool|null, bool, bool, string|null, Assertions, ?Type, array<string, Type>, array<(string|int), VarTag>, bool}
+	 * @return array{TemplateTypeMap, array<string, Type>, array<string, bool>, array<string, Type>, ?Type, ?Type, ?string, bool, bool, bool, bool|null, bool, bool, string|null, Assertions, ?Type, array<string, Type>, array<(string|int), VarTag>, bool, array<string, bool>}
 	 */
 	public function getPhpDocs(Scope $scope, Node\FunctionLike|Node\Stmt\Property $node): array
 	{
@@ -6694,6 +6694,7 @@ public function getPhpDocs(Scope $scope, Node\FunctionLike|Node\Stmt\Property $n
 		$resolvedPhpDoc = null;
 		$functionName = null;
 		$phpDocParameterOutTypes = [];
+		$phpDocPureUnlessCallableIsImpureParameters = [];
 
 		if ($node instanceof Node\Stmt\ClassMethod) {
 			if (!$scope->isInClass()) {
@@ -6821,9 +6822,10 @@ public function getPhpDocs(Scope $scope, Node\FunctionLike|Node\Stmt\Property $n
 			$asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
 			$selfOutType = $resolvedPhpDoc->getSelfOutTag() !== null ? $resolvedPhpDoc->getSelfOutTag()->getType() : null;
 			$varTags = $resolvedPhpDoc->getVarTags();
+			$phpDocPureUnlessCallableIsImpureParameters = $resolvedPhpDoc->getParamsPureUnlessCallableIsImpure();
 		}
 
-		return [$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, $isReadOnly, $docComment, $asserts, $selfOutType, $phpDocParameterOutTypes, $varTags, $isAllowedPrivateMutation];
+		return [$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, $isReadOnly, $docComment, $asserts, $selfOutType, $phpDocParameterOutTypes, $varTags, $isAllowedPrivateMutation, $phpDocPureUnlessCallableIsImpureParameters];
 	}
 
 	private function transformStaticType(ClassReflection $declaringClass, Type $type): Type
diff --git a/src/PhpDoc/PhpDocNodeResolver.php b/src/PhpDoc/PhpDocNodeResolver.php
@@ -428,16 +428,17 @@ public function resolveParamPureUnlessCallableIsImpure(PhpDocNode $phpDocNode):
 		$parameters = [];
 		// TODO: implement phpstan/phpdoc-parser
 		foreach ($phpDocNode->getTagsByName('@pure-unless-callable-impure') as $tag) {
-			$value = preg_split('/\s/u', (string)$tag->value)[0] ?? null;
-			if ($value !== null && str_starts_with($value, '$')) {
-				$parameters[substr($value, 1)] = true;
+			$value = preg_split('/\s/u', (string) $tag->value)[0] ?? null;
+			if ($value === null || !str_starts_with($value, '$')) {
+				continue;
 			}
+
+			$parameters[substr($value, 1)] = true;
 		}
 
 		return $parameters;
 	}
 
-
 	/**
 	 * @return array<string, ParamClosureThisTag>
 	 */
diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -1071,7 +1071,7 @@ private function inferAndCachePropertyTypes(
 			$classScope = $classScope->enterNamespace($namespace);
 		}
 		$classScope = $classScope->enterClass($declaringClass);
-		[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes] = $this->nodeScopeResolver->getPhpDocs($classScope, $methodNode);
+		[$templateTypeMap, $phpDocParameterTypes, $phpDocImmediatelyInvokedCallableParameters, $phpDocClosureThisTypeParameters, $phpDocReturnType, $phpDocThrowType, $deprecatedDescription, $isDeprecated, $isInternal, $isFinal, $isPure, $acceptsNamedArguments, , $phpDocComment, $asserts, $selfOutType, $phpDocParameterOutTypes, $varTags, $isAllowedPrivateMutation, $phpDocPureUnlessCallableIsImpureParameters] = $this->nodeScopeResolver->getPhpDocs($classScope, $methodNode);
 		$methodScope = $classScope->enterClassMethod(
 			$methodNode,
 			$templateTypeMap,
@@ -1090,6 +1090,7 @@ private function inferAndCachePropertyTypes(
 			$phpDocParameterOutTypes,
 			$phpDocImmediatelyInvokedCallableParameters,
 			$phpDocClosureThisTypeParameters,
+			$phpDocPureUnlessCallableIsImpureParameters,
 		);
 
 		$propertyTypes = [];
diff --git a/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php b/src/Reflection/Php/PhpFunctionFromParserNodeReflection.php
@@ -47,6 +47,7 @@ class PhpFunctionFromParserNodeReflection implements FunctionReflection, Extende
 	 * @param array<string, bool> $immediatelyInvokedCallableParameters
 	 * @param array<string, Type> $phpDocClosureThisTypeParameters
 	 * @param list<AttributeReflection> $attributes
+	 * @param array<string, bool> $pureUnlessCallableIsImpureParameters
 	 */
 	public function __construct(
 		FunctionLike $functionLike,
@@ -70,6 +71,7 @@ public function __construct(
 		private array $immediatelyInvokedCallableParameters,
 		private array $phpDocClosureThisTypeParameters,
 		private array $attributes,
+		private array $pureUnlessCallableIsImpureParameters,
 	)
 	{
 		$this->functionLike = $functionLike;
diff --git a/src/Reflection/Php/PhpMethodFromParserNodeReflection.php b/src/Reflection/Php/PhpMethodFromParserNodeReflection.php
@@ -68,6 +68,7 @@ public function __construct(
 		array $phpDocClosureThisTypeParameters,
 		private bool $isConstructor,
 		array $attributes,
+		array $pureUnlessCallableIsImpureParameters,
 	)
 	{
 		if ($this->classMethod instanceof Node\PropertyHook) {
@@ -136,6 +137,7 @@ public function __construct(
 			$immediatelyInvokedCallableParameters,
 			$phpDocClosureThisTypeParameters,
 			$attributes,
+			$pureUnlessCallableIsImpureParameters,
 		);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ public function __construct(`
`68`	`68`	`array $phpDocClosureThisTypeParameters,`
`69`	`69`	`private bool $isConstructor,`
`70`	`70`	`array $attributes,`
	`71`	`+ array $pureUnlessCallableIsImpureParameters,`
`71`	`72`	`)`
`72`	`73`	`{`
`73`	`74`	`if ($this->classMethod instanceof Node\PropertyHook) {`
`@@ -136,6 +137,7 @@ public function __construct(`
`136`	`137`	`$immediatelyInvokedCallableParameters,`
`137`	`138`	`$phpDocClosureThisTypeParameters,`
`138`	`139`	`$attributes,`
	`140`	`+ $pureUnlessCallableIsImpureParameters,`
`139`	`141`	`);`
`140`	`142`	`}`
`141`	`143`