InvalidPromotedPropertiesRule - report final in promoted property on PHP < 8.5

Author: ondrejmirtes

src/Php/PhpVersion.php

@@ -424,4 +424,9 @@ public function deprecatesNullArrayOffset(): bool
 		return $this->versionId >= 80500;
 	}
 
+	public function supportsFinalPromotedProperties(): bool
+	{
+		return $this->versionId >= 80500;
+	}
+
 }

src/Rules/Classes/InvalidPromotedPropertiesRule.php

@@ -89,6 +89,12 @@ public function processNode(Node $node, Scope $scope): array
 				throw new ShouldNotHappenException();
 			}
 
+			if ($param->isFinal() && !$this->phpVersion->supportsFinalPromotedProperties()) {
+				$errors[] = RuleErrorBuilder::message(
+					'Final promoted properties are supported only on PHP 8.5 and later.',
+				)->identifier('property.invalidPromoted')->nonIgnorable()->line($param->getStartLine())->build();
+			}
+
 			if (!$param->variadic) {
 				continue;
 			}

tests/PHPStan/Rules/Classes/InvalidPromotedPropertiesRuleTest.php

@@ -6,6 +6,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\RequiresPhp;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<InvalidPromotedPropertiesRule>
@@ -113,4 +114,19 @@ public function testHooks(): void
 		]);
 	}
 
+	public function testFinalProperty(): void
+	{
+		$this->phpVersion = PHP_VERSION_ID;
+		$errors = [];
+		if (PHP_VERSION_ID < 80500) {
+			$errors = [
+				[
+					'Final promoted properties are supported only on PHP 8.5 and later.',
+					8,
+				],
+			];
+		}
+		$this->analyse([__DIR__ . '/data/final-promoted-property.php'], $errors);
+	}
+
 }

tests/PHPStan/Rules/Classes/data/final-promoted-property.php

@@ -0,0 +1,12 @@
+<?php // lint >= 8.5
+
+namespace FinalPromotedProperty;
+
+class Foo
+{
+
+	public function __construct(final $i) {
+
+	}
+
+}