Fix special implode behaviour in pipe operator

ondrejmirtes · ondrejmirtes · commit d0ae37e20407 · 2025-10-23T11:40:11.000+02:00
diff --git a/src/Analyser/NodeScopeResolver.php b/src/Analyser/NodeScopeResolver.php
@@ -132,6 +132,7 @@
 use PHPStan\Parser\ImmediatelyInvokedClosureVisitor;
 use PHPStan\Parser\LineAttributesVisitor;
 use PHPStan\Parser\Parser;
+use PHPStan\Parser\ReversePipeTransformerVisitor;
 use PHPStan\Php\PhpVersion;
 use PHPStan\PhpDoc\PhpDocInheritanceResolver;
 use PHPStan\PhpDoc\ResolvedPhpDocBlock;
@@ -3385,7 +3386,7 @@ static function (): void {
 		} elseif ($expr instanceof BinaryOp\Pipe) {
 			if ($expr->right instanceof FuncCall && $expr->right->isFirstClassCallable()) {
 				$exprResult = $this->processExprNode($stmt, new FuncCall($expr->right->name, [
-					new Arg($expr->left, attributes: $expr->left->getAttributes()),
+					new Arg($expr->left, attributes: $expr->getAttribute(ReversePipeTransformerVisitor::ARG_ATTRIBUTES_NAME, [])),
 				], array_merge($expr->right->getAttributes(), ['virtualPipeOperatorCall' => true])), $scope, $nodeCallback, $context);
 				$scope = $exprResult->getScope();
 				$hasYield = $exprResult->hasYield();
@@ -3394,7 +3395,7 @@ static function (): void {
 				$isAlwaysTerminating = $exprResult->isAlwaysTerminating();
 			} elseif ($expr->right instanceof MethodCall && $expr->right->isFirstClassCallable()) {
 				$exprResult = $this->processExprNode($stmt, new MethodCall($expr->right->var, $expr->right->name, [
-					new Arg($expr->left, attributes: $expr->left->getAttributes()),
+					new Arg($expr->left, attributes: $expr->getAttribute(ReversePipeTransformerVisitor::ARG_ATTRIBUTES_NAME, [])),
 				], array_merge($expr->right->getAttributes(), ['virtualPipeOperatorCall' => true])), $scope, $nodeCallback, $context);
 				$scope = $exprResult->getScope();
 				$hasYield = $exprResult->hasYield();
@@ -3403,7 +3404,7 @@ static function (): void {
 				$isAlwaysTerminating = $exprResult->isAlwaysTerminating();
 			} elseif ($expr->right instanceof StaticCall && $expr->right->isFirstClassCallable()) {
 				$exprResult = $this->processExprNode($stmt, new StaticCall($expr->right->class, $expr->right->name, [
-					new Arg($expr->left, attributes: $expr->left->getAttributes()),
+					new Arg($expr->left, attributes: $expr->getAttribute(ReversePipeTransformerVisitor::ARG_ATTRIBUTES_NAME, [])),
 				], array_merge($expr->right->getAttributes(), ['virtualPipeOperatorCall' => true])), $scope, $nodeCallback, $context);
 				$scope = $exprResult->getScope();
 				$hasYield = $exprResult->hasYield();
@@ -3412,7 +3413,7 @@ static function (): void {
 				$isAlwaysTerminating = $exprResult->isAlwaysTerminating();
 			} else {
 				$exprResult = $this->processExprNode($stmt, new FuncCall($expr->right, [
-					new Arg($expr->left, attributes: $expr->left->getAttributes()),
+					new Arg($expr->left, attributes: $expr->getAttribute(ReversePipeTransformerVisitor::ARG_ATTRIBUTES_NAME, [])),
 				], array_merge($expr->right->getAttributes(), ['virtualPipeOperatorCall' => true])), $scope, $nodeCallback, $context);
 				$scope = $exprResult->getScope();
 				$hasYield = $exprResult->hasYield();
diff --git a/src/Parser/CurlSetOptArgVisitor.php b/src/Parser/CurlSetOptArgVisitor.php
@@ -19,7 +19,7 @@ public function enterNode(Node $node): ?Node
 		if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {
 			$functionName = $node->name->toLowerString();
 			if ($functionName === 'curl_setopt') {
-				$args = $node->getRawArgs();
+				$args = $node->getArgs();
 				if (isset($args[0])) {
 					$args[0]->setAttribute(self::ATTRIBUTE_NAME, true);
 				}
diff --git a/src/Parser/CurlSetOptArrayArgVisitor.php b/src/Parser/CurlSetOptArrayArgVisitor.php
@@ -16,10 +16,10 @@ final class CurlSetOptArrayArgVisitor extends NodeVisitorAbstract
 	#[Override]
 	public function enterNode(Node $node): ?Node
 	{
-		if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name) {
+		if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {
 			$functionName = $node->name->toLowerString();
 			if ($functionName === 'curl_setopt_array') {
-				$args = $node->getRawArgs();
+				$args = $node->getArgs();
 				if (isset($args[1])) {
 					$args[1]->setAttribute(self::ATTRIBUTE_NAME, true);
 				}
diff --git a/src/Parser/ImplodeArgVisitor.php b/src/Parser/ImplodeArgVisitor.php
@@ -20,7 +20,7 @@ public function enterNode(Node $node): ?Node
 		if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {
 			$functionName = $node->name->toLowerString();
 			if (in_array($functionName, ['implode', 'join'], true)) {
-				$args = $node->getRawArgs();
+				$args = $node->getArgs();
 				if (isset($args[0])) {
 					$args[0]->setAttribute(self::ATTRIBUTE_NAME, true);
 				}
diff --git a/src/Parser/ReversePipeTransformerVisitor.php b/src/Parser/ReversePipeTransformerVisitor.php
@@ -10,13 +10,16 @@
 final class ReversePipeTransformerVisitor extends NodeVisitorAbstract
 {
 
+	public const ARG_ATTRIBUTES_NAME = 'argAttributes';
+
 	#[Override]
 	public function enterNode(Node $node): ?Node
 	{
 		if ($node instanceof Node\Expr\FuncCall && !$node->isFirstClassCallable()) {
 			$attributes = $node->getAttributes();
 			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
 			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				$origPipeAttributes[self::ARG_ATTRIBUTES_NAME] = $node->getArgs()[0]->getAttributes();
 				if ($node->name instanceof Node\Name) {
 					unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
 					return new Node\Expr\BinaryOp\Pipe(
@@ -38,6 +41,7 @@ public function enterNode(Node $node): ?Node
 			$attributes = $node->getAttributes();
 			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
 			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				$origPipeAttributes[self::ARG_ATTRIBUTES_NAME] = $node->getArgs()[0]->getAttributes();
 				unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
 				return new Node\Expr\BinaryOp\Pipe(
 					$node->getArgs()[0]->value,
@@ -51,6 +55,7 @@ public function enterNode(Node $node): ?Node
 			$attributes = $node->getAttributes();
 			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
 			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				$origPipeAttributes[self::ARG_ATTRIBUTES_NAME] = $node->getArgs()[0]->getAttributes();
 				unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
 				return new Node\Expr\BinaryOp\Pipe(
 					$node->getArgs()[0]->value,
diff --git a/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php b/tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
@@ -2431,6 +2431,14 @@ public function testPipeOperator(): void
 				'Result of function FuncCallPipe\doBar (void) is used.',
 				28,
 			],
+			[
+				'Parameter #1 $separator of function implode expects array, string given.',
+				38,
+			],
+			[
+				'Parameter #1 $separator of function implode expects array, string given.',
+				40,
+			],
 		]);
 	}
 
diff --git a/tests/PHPStan/Rules/Functions/data/func-call-pipe.php b/tests/PHPStan/Rules/Functions/data/func-call-pipe.php
@@ -29,3 +29,15 @@ public function doFoo(): void
 	}
 
 }
+
+class TestImplode
+{
+
+	public function doFoo(): void
+	{
+		implode('foo');
+
+		'foo' |> implode(...);
+	}
+
+}

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public function enterNode(Node $node): ?Node`
`19`	`19`	`if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {`
`20`	`20`	`$functionName = $node->name->toLowerString();`
`21`	`21`	`if ($functionName === 'curl_setopt') {`
`22`		`- $args = $node->getRawArgs();`
	`22`	`+ $args = $node->getArgs();`
`23`	`23`	`if (isset($args[0])) {`
`24`	`24`	`$args[0]->setAttribute(self::ATTRIBUTE_NAME, true);`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,10 +16,10 @@ final class CurlSetOptArrayArgVisitor extends NodeVisitorAbstract`
`16`	`16`	`#[Override]`
`17`	`17`	`public function enterNode(Node $node): ?Node`
`18`	`18`	`{`
`19`		`- if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name) {`
	`19`	`+ if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {`
`20`	`20`	`$functionName = $node->name->toLowerString();`
`21`	`21`	`if ($functionName === 'curl_setopt_array') {`
`22`		`- $args = $node->getRawArgs();`
	`22`	`+ $args = $node->getArgs();`
`23`	`23`	`if (isset($args[1])) {`
`24`	`24`	`$args[1]->setAttribute(self::ATTRIBUTE_NAME, true);`
`25`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public function enterNode(Node $node): ?Node`
`20`	`20`	`if ($node instanceof Node\Expr\FuncCall && $node->name instanceof Node\Name && !$node->isFirstClassCallable()) {`
`21`	`21`	`$functionName = $node->name->toLowerString();`
`22`	`22`	`if (in_array($functionName, ['implode', 'join'], true)) {`
`23`		`- $args = $node->getRawArgs();`
	`23`	`+ $args = $node->getArgs();`
`24`	`24`	`if (isset($args[0])) {`
`25`	`25`	`$args[0]->setAttribute(self::ATTRIBUTE_NAME, true);`
`26`	`26`	`}`