IllegalConstructorStaticCallRule - allow call parent of a parent

Author: ondrejmirtes

src/Rules/Methods/IllegalConstructorStaticCallRule.php

@@ -6,6 +6,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use function array_map;
+use function in_array;
+use function strtolower;
 
 /**
  * @implements Rule<Node\Expr\StaticCall>
@@ -52,7 +55,9 @@ private function isCollectCallingConstructor(Node $node, Scope $scope): bool
 			return false;
 		}
 
-		return $node->class->toLowerString() === 'parent';
+		$parentClasses = array_map(static fn (string $name) => strtolower($name), $scope->getClassReflection()->getParentClassesNames());
+
+		return in_array(strtolower($scope->resolveName($node->class)), $parentClasses, true);
 	}
 
 }

tests/PHPStan/Rules/Methods/IllegalConstructorStaticCallRuleTest.php

@@ -39,6 +39,10 @@ public function testMethods(): void
 				'Static call to __construct() is only allowed on a parent class in the constructor.',
 				50,
 			],
+			[
+				'Static call to __construct() is only allowed on a parent class in the constructor.',
+				100,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Methods/data/illegal-constructor-call-rule-test.php

@@ -61,3 +61,43 @@ public function doFoo()
 	}
 
 }
+
+abstract class Presenter
+{
+
+	public function __construct()
+	{
+
+	}
+
+}
+
+abstract class BasePresenter extends Presenter
+{
+
+	public function __construct()
+	{
+		Presenter::__construct();
+	}
+
+}
+
+class CatPresenter extends BasePresenter
+{
+
+	public function __construct()
+	{
+		Presenter::__construct();
+	}
+
+}
+
+class DogPresenter extends BasePresenter
+{
+
+	public function __construct()
+	{
+		CatPresenter::__construct();
+	}
+
+}