Use InTraitNode instead

Some attribute arguments actually depend on using class instead of the trait

So we have to analyse the attributes in context of each class that uses the trait

Author: ondrejmirtes

src/Rules/Traits/TraitAttributesRule.php

@@ -4,62 +4,41 @@
 
 use Attribute;
 use PhpParser\Node;
-use PhpParser\Node\Stmt\Class_;
-use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\ReflectionProvider;
+use PHPStan\Node\InTraitNode;
 use PHPStan\Rules\AttributesCheck;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
-use PHPStan\ShouldNotHappenException;
 use function count;
 
 /**
- * @implements Rule<Node\Stmt\Trait_>
+ * @implements Rule<InTraitNode>
  */
 final class TraitAttributesRule implements Rule
 {
 
 	public function __construct(
 		private AttributesCheck $attributesCheck,
-		private ReflectionProvider $reflectionProvider,
 	)
 	{
 	}
 
 	public function getNodeType(): string
 	{
-		return Node\Stmt\Trait_::class;
+		return InTraitNode::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$traitName = $node->namespacedName;
-		if ($traitName === null) {
-			return [];
-		}
-
-		if (!$this->reflectionProvider->hasClass($traitName->toString())) {
-			return [];
-		}
-		$traitClassReflection = $this->reflectionProvider->getClass($traitName->toString());
-
-		if (!$scope instanceof MutatingScope) {
-			throw new ShouldNotHappenException();
-		}
-		$fakeClass = new Class_(null, [new Node\Stmt\TraitUse([$traitName])], ['startLine' => 1, 'endLine' => 1]);
-		$fakeClassReflection = $this->reflectionProvider->getAnonymousClassReflection($fakeClass, $scope);
-		$scope = $scope->enterClass($fakeClassReflection);
-		$scope = $scope->enterTrait($traitClassReflection);
-
+		$originalNode = $node->getOriginalNode();
 		$errors = $this->attributesCheck->check(
 			$scope,
-			$node->attrGroups,
+			$originalNode->attrGroups,
 			Attribute::TARGET_CLASS,
 			'class',
 		);
 
-		if (count($traitClassReflection->getNativeReflection()->getAttributes('AllowDynamicProperties')) > 0) {
+		if (count($node->getTraitReflection()->getNativeReflection()->getAttributes('AllowDynamicProperties')) > 0) {
 			$errors[] = RuleErrorBuilder::message('Attribute class AllowDynamicProperties cannot be used with trait.')
 				->identifier('trait.allowDynamicProperties')
 				->nonIgnorable()

tests/PHPStan/Rules/Traits/TraitAttributesRuleTest.php

@@ -5,7 +5,6 @@
 use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\AttributesCheck;
 use PHPStan\Rules\ClassCaseSensitivityCheck;
-use PHPStan\Rules\Classes\ClassAttributesRule;
 use PHPStan\Rules\ClassForbiddenNameCheck;
 use PHPStan\Rules\ClassNameCheck;
 use PHPStan\Rules\FunctionCallParametersCheck;
@@ -14,7 +13,6 @@
 use PHPStan\Rules\Properties\PropertyReflectionFinder;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
-use PHPStan\Rules\Traits\TraitAttributesRule;
 use PHPStan\Testing\RuleTestCase;
 use const PHP_VERSION_ID;
 
@@ -51,7 +49,6 @@ protected function getRule(): Rule
 				),
 				true,
 			),
-			$reflectionProvider,
 		);
 	}
 

tests/PHPStan/Rules/Traits/data/bug-12281.php

@@ -10,3 +10,10 @@ interface BlogDataInterface { /* … */ } // reported by ClassAttributesRule
 
 #[\AllowDynamicProperties]
 trait BlogDataTrait { /* … */ }
+
+class Uses
+{
+
+	use BlogDataTrait;
+
+}

tests/PHPStan/Rules/Traits/data/trait-attributes.php

@@ -19,3 +19,12 @@ class MyTargettedAttribute {}
 
 #[MyTargettedAttribute]
 trait MyTrait3 {}
+
+class Uses
+{
+
+	use MyTrait;
+	use MyTrait2;
+	use MyTrait3;
+
+}