Skip to content

Commit 8b57d0c

Browse files
takaramondrejmirtes
authored andcommitted
Refactor FunctionCallParametersCheck
`$parameterCount` is always >0 when `$isNativelyVariadic` is true
1 parent b4b3e73 commit 8b57d0c

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/Rules/FunctionCallParametersCheck.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -603,12 +603,7 @@ private function processArguments(
603603
} else {
604604
$namedArgumentAlreadyOccurred = true;
605605

606-
$parametersCount = count($parameters);
607-
if (
608-
!$isNativelyVariadic
609-
|| $parametersCount <= 0
610-
|| $isBuiltin
611-
) {
606+
if (!$isNativelyVariadic || $isBuiltin) {
612607
$errors[] = RuleErrorBuilder::message(sprintf($unknownParameterMessage, $argumentName))
613608
->identifier('argument.unknown')
614609
->line($argumentLine)
@@ -617,6 +612,7 @@ private function processArguments(
617612
continue;
618613
}
619614

615+
$parametersCount = count($parameters);
620616
$parameter = $parameters[$parametersCount - 1];
621617
$originalParameter = $originalParameters[$parametersCount - 1];
622618
}

0 commit comments

Comments
 (0)