AssignToByRefExprFromForeachRule - do not report foreach itself when inside another loop

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -1278,7 +1278,7 @@ private function processStmtNode(
 			if (!(new ObjectType(Traversable::class))->isSuperTypeOf($scope->getType($stmt->expr))->no()) {
 				$throwPoints[] = ThrowPoint::createImplicit($scope, $stmt->expr);
 			}
-			if ($stmt->byRef) {
+			if ($context->isTopLevel() && $stmt->byRef) {
 				$finalScope = $finalScope->assignExpression(new ForeachValueByRefExpr($stmt->valueVar), new MixedType(), new MixedType());
 			}
 

tests/PHPStan/Rules/Variables/data/assign-to-by-ref-expr-from-foreach.php

@@ -64,4 +64,14 @@ public function doFoo3(): void
 		}
 	}
 
+	public function doFoo4(): void
+	{
+		while (true) {
+			$array = [0, 1, 2, 3];
+			foreach ($array as &$item) {
+
+			}
+		}
+	}
+
 }