CompileCommand - do not run Box

Author: ondrejmirtes

.github/workflows/phar.yml

@@ -46,10 +46,14 @@ jobs:
         working-directory: "compiler"
         run: "../bin/phpstan analyse -l 8 src tests"
 
-      - name: "Compiler PHAR"
+      - name: "Prepare for PHAR compilation"
         working-directory: "compiler"
         run: "php bin/compile"
 
+      - name: "Compile PHAR"
+        working-directory: "compiler/build"
+        run: "php box.phar compile --no-parallel"
+
       - name: "Run PHAR"
         run: "./tmp/phpstan.phar list"
 

compiler/bin/compile

@@ -3,15 +3,12 @@
 
 use PHPStan\Compiler\Console\CompileCommand;
 use PHPStan\Compiler\Filesystem\SymfonyFilesystem;
-use PHPStan\Compiler\Process\DefaultProcessFactory;
 use Symfony\Component\Console\Application;
 
 require_once __DIR__ . '/../vendor/autoload.php';
 
 $compileCommand = new CompileCommand(
 	new SymfonyFilesystem(new \Symfony\Component\Filesystem\Filesystem()),
-	new DefaultProcessFactory(),
-	__DIR__ . '/../build',
 	realpath(__DIR__ . '/../..')
 );
 

compiler/src/Console/CompileCommand.php

@@ -4,7 +4,6 @@
 
 use Exception;
 use PHPStan\Compiler\Filesystem\Filesystem;
-use PHPStan\Compiler\Process\ProcessFactory;
 use PHPStan\ShouldNotHappenException;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -36,8 +35,6 @@ final class CompileCommand extends Command
 
 	public function __construct(
 		private Filesystem $filesystem,
-		private ProcessFactory $processFactory,
-		private string $dataDir,
 		private string $buildDir,
 	)
 	{
@@ -52,17 +49,12 @@ protected function configure(): void
 
 	protected function execute(InputInterface $input, OutputInterface $output): int
 	{
-		$this->processFactory->setOutput($output);
-
 		$this->buildPreloadScript();
 		$this->deleteUnnecessaryVendorCode();
 		$this->fixComposerJson($this->buildDir);
 		$this->renamePhpStormStubs();
 		$this->renamePhp8Stubs();
 		$this->transformSource();
-
-		$this->processFactory->create(['php', 'box.phar', 'compile', '--no-parallel'], $this->dataDir);
-
 		return 0;
 	}
 

compiler/src/Process/DefaultProcessFactory.php

@@ -1 +1 @@
-C:37:"PHPUnit\Runner\DefaultTestResultCache":636:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:8:{s:56:"PHPStan\Compiler\Console\CompileCommandTest::testCommand";d:0.053;s:61:"PHPStan\Compiler\Filesystem\SymfonyFilesystemTest::testExists";d:0.01;s:61:"PHPStan\Compiler\Filesystem\SymfonyFilesystemTest::testRemove";d:0;s:60:"PHPStan\Compiler\Filesystem\SymfonyFilesystemTest::testMkdir";d:0;s:59:"PHPStan\Compiler\Filesystem\SymfonyFilesystemTest::testRead";d:0;s:60:"PHPStan\Compiler\Filesystem\SymfonyFilesystemTest::testWrite";d:0.008;s:62:"PHPStan\Compiler\Process\DefaultProcessFactoryTest::testCreate";d:0.058;s:59:"PHPStan\Compiler\Process\SymfonyProcessTest::testGetProcess";d:0.01;}}}
+{"version":1,"defects":[],"times":{"PHPStan\\Compiler\\Filesystem\\SymfonyFilesystemTest::testExists":0.014,"PHPStan\\Compiler\\Filesystem\\SymfonyFilesystemTest::testRemove":0,"PHPStan\\Compiler\\Filesystem\\SymfonyFilesystemTest::testMkdir":0,"PHPStan\\Compiler\\Filesystem\\SymfonyFilesystemTest::testRead":0,"PHPStan\\Compiler\\Filesystem\\SymfonyFilesystemTest::testWrite":0}}