RichParser - transform pipes into ordinary calls for custom visitors, and then back

Author: ondrejmirtes

src/Parser/ArrowFunctionPipeVisitor.php

@@ -0,0 +1,56 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Parser;
+
+use Override;
+use PhpParser\Node;
+use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\NodeVisitorAbstract;
+use function array_merge;
+
+final class PipeTransformerVisitor extends NodeVisitorAbstract
+{
+
+	public const ORIGINAL_PIPE_ATTRIBUTE_NAME = 'originalPipeAttrs';
+
+	#[Override]
+	public function enterNode(Node $node): ?Node
+	{
+		if (!$node instanceof Node\Expr\BinaryOp\Pipe) {
+			return null;
+		}
+
+		if ($node->right instanceof Node\Expr\FuncCall && $node->right->isFirstClassCallable()) {
+			return new FuncCall($node->right->name, [
+				new Arg($node->left),
+			], attributes: array_merge($node->right->getAttributes(), [
+				self::ORIGINAL_PIPE_ATTRIBUTE_NAME => $node->getAttributes(),
+			]));
+		}
+
+		if ($node->right instanceof MethodCall && $node->right->isFirstClassCallable()) {
+			return new MethodCall($node->right->var, $node->right->name, [
+				new Arg($node->left),
+			], attributes: array_merge($node->right->getAttributes(), [
+				self::ORIGINAL_PIPE_ATTRIBUTE_NAME => $node->getAttributes(),
+			]));
+		}
+
+		if ($node->right instanceof Node\Expr\StaticCall && $node->right->isFirstClassCallable()) {
+			return new Node\Expr\StaticCall($node->right->class, $node->right->name, [
+				new Arg($node->left),
+			], attributes: array_merge($node->right->getAttributes(), [
+				self::ORIGINAL_PIPE_ATTRIBUTE_NAME => $node->getAttributes(),
+			]));
+		}
+
+		return new FuncCall($node->right, [
+			new Arg($node->left),
+		], attributes: [
+			self::ORIGINAL_PIPE_ATTRIBUTE_NAME => $node->getAttributes(),
+		]);
+	}
+
+}

src/Parser/ClosurePipeVisitor.php

@@ -0,0 +1,58 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Parser;
+
+use Override;
+use PhpParser\Node;
+use PhpParser\NodeVisitorAbstract;
+use function count;
+
+final class ReversePipeTransformerVisitor extends NodeVisitorAbstract
+{
+
+	#[Override]
+	public function enterNode(Node $node): ?Node
+	{
+		if ($node instanceof Node\Expr\FuncCall && !$node->isFirstClassCallable()) {
+			$attributes = $node->getAttributes();
+			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
+			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
+				return new Node\Expr\BinaryOp\Pipe(
+					$node->getArgs()[0]->value,
+					new Node\Expr\FuncCall($node->name, [new Node\VariadicPlaceholder()], attributes: $attributes),
+					attributes: $origPipeAttributes,
+				);
+			}
+		}
+
+		if ($node instanceof Node\Expr\MethodCall && !$node->isFirstClassCallable()) {
+			$attributes = $node->getAttributes();
+			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
+			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
+				return new Node\Expr\BinaryOp\Pipe(
+					$node->getArgs()[0]->value,
+					new Node\Expr\MethodCall($node->var, $node->name, [new Node\VariadicPlaceholder()], attributes: $attributes),
+					attributes: $origPipeAttributes,
+				);
+			}
+		}
+
+		if ($node instanceof Node\Expr\StaticCall && !$node->isFirstClassCallable()) {
+			$attributes = $node->getAttributes();
+			$origPipeAttributes = $attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME] ?? [];
+			if ($origPipeAttributes !== [] && count($node->getArgs()) === 1) {
+				unset($attributes[PipeTransformerVisitor::ORIGINAL_PIPE_ATTRIBUTE_NAME]);
+				return new Node\Expr\BinaryOp\Pipe(
+					$node->getArgs()[0]->value,
+					new Node\Expr\StaticCall($node->class, $node->name, [new Node\VariadicPlaceholder()], attributes: $attributes),
+					attributes: $origPipeAttributes,
+				);
+			}
+		}
+
+		return null;
+	}
+
+}

src/Parser/PipeTransformerVisitor.php

@@ -77,6 +77,10 @@ public function parseString(string $sourceCode): array
 			throw new ShouldNotHappenException();
 		}
 
+		$pipeTransformer = new NodeTraverser(new PipeTransformerVisitor());
+		/** @var array<Node\Stmt> */
+		$nodes = $pipeTransformer->traverse($nodes);
+
 		$nodeTraverser = new NodeTraverser();
 		$nodeTraverser->addVisitor($this->nameResolver);
 
@@ -89,6 +93,11 @@ public function parseString(string $sourceCode): array
 
 		/** @var array<Node\Stmt> */
 		$nodes = $nodeTraverser->traverse($nodes);
+
+		$reversePipeTransformer = new NodeTraverser(new ReversePipeTransformerVisitor());
+		/** @var array<Node\Stmt> */
+		$nodes = $reversePipeTransformer->traverse($nodes);
+
 		['lines' => $linesToIgnore, 'errors' => $ignoreParseErrors] = $this->getLinesToIgnore($tokens);
 		if (isset($nodes[0])) {
 			$nodes[0]->setAttribute('linesToIgnore', $linesToIgnore);