extract PHPUnit method call detection to helper

Author: mhujer

src/Rules/PHPUnit/AssertRuleHelper.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\PHPUnit;
+
+use PhpParser\Node;
+use PHPStan\Analyser\Scope;
+use PHPStan\Type\ObjectType;
+
+class AssertRuleHelper
+{
+
+	/**
+	 * @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
+	 * @param \PHPStan\Analyser\Scope $scope
+	 * @return bool
+	 */
+	public static function isMethodOrStaticCallOnTestCase(Node $node, Scope $scope): bool
+	{
+		$testCaseType = new ObjectType(\PHPUnit\Framework\TestCase::class);
+		if ($node instanceof Node\Expr\MethodCall) {
+			$calledOnType = $scope->getType($node->var);
+		} elseif ($node instanceof Node\Expr\StaticCall) {
+			if ($node->class instanceof Node\Name) {
+				$class = (string) $node->class;
+				if (in_array(
+					strtolower($class),
+					[
+						'self',
+						'static',
+						'parent',
+					],
+					true
+				)) {
+					$calledOnType = new ObjectType($scope->getClassReflection()->getName());
+				} else {
+					$calledOnType = new ObjectType($class);
+				}
+			} else {
+				$calledOnType = $scope->getType($node->class);
+			}
+		} else {
+			return false;
+		}
+
+		if (!$testCaseType->isSuperTypeOf($calledOnType)->yes()) {
+			return false;
+		}
+
+		return true;
+	}
+
+}

src/Rules/PHPUnit/AssertSameDifferentTypesRule.php

@@ -4,7 +4,6 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use PHPStan\Type\ObjectType;
 
 class AssertSameDifferentTypesRule implements \PHPStan\Rules\Rule
 {
@@ -21,33 +20,7 @@ public function getNodeType(): string
 	 */
 	public function processNode(Node $node, Scope $scope): array
 	{
-		$testCaseType = new ObjectType(\PHPUnit\Framework\TestCase::class);
-		if ($node instanceof Node\Expr\MethodCall) {
-			$calledOnType = $scope->getType($node->var);
-		} elseif ($node instanceof Node\Expr\StaticCall) {
-			if ($node->class instanceof Node\Name) {
-				$class = (string) $node->class;
-				if (in_array(
-					strtolower($class),
-					[
-						'self',
-						'static',
-						'parent',
-					],
-					true
-				)) {
-					$calledOnType = new ObjectType($scope->getClassReflection()->getName());
-				} else {
-					$calledOnType = new ObjectType($class);
-				}
-			} else {
-				$calledOnType = $scope->getType($node->class);
-			}
-		} else {
-			return [];
-		}
-
-		if (!$testCaseType->isSuperTypeOf($calledOnType)->yes()) {
+		if (!AssertRuleHelper::isMethodOrStaticCallOnTestCase($node, $scope)) {
 			return [];
 		}